Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fable JS support #657

Merged
merged 1 commit into from
Jan 22, 2017
Merged

Conversation

ncave
Copy link
Collaborator

@ncave ncave commented Jan 17, 2017

  • Compiling Fable with Fable works
  • Babel AST JS output works
  • Demo JS page works
  • Next step: To be determined by community, open for suggestions.

Disclaimer: This is a rough POC, corners have been cut to get to MVP faster.
That said, it works (but then we'll have to go back and add some corners).

Dependency: FCS for Fable
Build instructions: TBD

@ncave
Copy link
Collaborator Author

ncave commented Jan 21, 2017

@alfonsogarciacaro I think this is ready for merging, please let me know what you think.
It does not affect normal Fable as all code is behind #ifdefs, and all tests are passing.
Also, we can start working on a Fable Live JS page, it will be a nice showcase for Fable.

@alfonsogarciacaro
Copy link
Member

Awesome work @ncave, thanks a lot for this! 👏 👏 👏

I've created a new branch to start working in the release of Fable 1.0 (codename narumi) to unify the .NET/Mono and Netcore versions and include the integration with dotnet SDK #584. I think it may be a good idea to make the merge directly in that branch. If you agree, could you please change the target of the PR?

@ncave ncave changed the base branch from master to narumi January 22, 2017 14:41
@ncave ncave changed the base branch from narumi to master January 22, 2017 14:42
@ncave ncave changed the base branch from master to narumi January 22, 2017 14:57
@ncave
Copy link
Collaborator Author

ncave commented Jan 22, 2017

@alfonsogarciacaro Target changed.

@alfonsogarciacaro alfonsogarciacaro merged commit 026d1a3 into fable-compiler:narumi Jan 22, 2017
alfonsogarciacaro pushed a commit that referenced this pull request Jan 25, 2017
alfonsogarciacaro pushed a commit that referenced this pull request Jan 25, 2017
alfonsogarciacaro pushed a commit that referenced this pull request Jan 26, 2017
@ncave ncave deleted the fable branch February 1, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants