Make sure to read the last snapshot and fix deserializing data #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipgiuliani
commented
Feb 16, 2024
| @@ -140,7 +140,8 @@ defmodule Commanded.EventStore.Adapters.Spear.Mapper do | |||
| |> Spear.Event.to_proposed_message(%{serializer_content_type => &serializer.serialize/1}) | |||
| end | |||
|
|
|||
| def to_snapshot_data(%RecordedEvent{data: %SnapshotData{} = snapshot} = event) do | |||
| def to_snapshot_data(%RecordedEvent{data: %SnapshotData{} = snapshot} = event) | |||
There was a problem hiding this comment.
When using the JSON instead of the TermSerializer the snapshot.data isn't a struct yet and we need to proceed to the next case which uses the JsonDecoder.
There was a problem hiding this comment.
Without this fix the snapshot.data remains just a map.
philipgiuliani
changed the title
fabriziosestito
approved these changes
Feb 20, 2024
|
No problem, thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1: Even though the combination of
startandbackwardsseems to make sense, this implementation was not correct. The EventStore returns the first snapshot in this case instead of the last snapshot. Unfortunately this doesn't seem to be covered by the Commanded Testsuite.Issue 2: The snapshot.data was not decoded to a struct but just to a map, which caused the ProcessManager to not match any of the
handleclauses.