-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YV4: wf: Revise sensor name to comply naming rule #2032
YV4: wf: Revise sensor name to comply naming rule #2032
Conversation
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Description: - Revise the descriptor part of sensor name. - Revise the fru name of the sensor name to be in uppercase. Motivation: - Revise sensor name to comply naming rules. Note: - Related JIRA link: https://metainfra.atlassian.net/browse/YV4T1M-1070 Test Plan: - Build code: Pass - Check sensor name: Pass Test Log: - Revised sensor name root@bmc:~# busctl tree xyz.openbmc_project.PLDM | grep WAILUA_FALLS_SLOT_1_ | wc -l 67 root@bmc:~# busctl tree xyz.openbmc_project.PLDM | grep WAILUA_FALLS_SLOT_1_ │ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_PMON_E1S0_P12V_CURR_A │ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_PMON_P12V_STBY_CURR_A │ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V85_CURR_A │ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V8_CURR_A │ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_AB_CURR_A │ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_CD_CURR_A │ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V85_CURR_A │ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V8_CURR_A │ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_AB_CURR_A │ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_CD_CURR_A │ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_PMON_E1S0_P12V_PWR_W │ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_PMON_P12V_STBY_PWR_W │ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V85_PWR_W │ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V8_PWR_W │ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_AB_PWR_W │ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_CD_PWR_W │ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V85_PWR_W │ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V8_PWR_W │ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_AB_PWR_W │ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_CD_PWR_W │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC1_DIMM_A_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC1_DIMM_B_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC1_DIMM_C_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC1_DIMM_D_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC2_DIMM_A_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC2_DIMM_B_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC2_DIMM_C_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC2_DIMM_D_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_CXL1_CNTR_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_CXL2_CNTR_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_E1S_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_INLET_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V85_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V8_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_AB_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_CD_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V85_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V8_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_AB_TEMP_C │ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_CD_TEMP_C │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_P0V75_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_P1V2_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_P1V8_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_PVPP_AB_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_PVPP_CD_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_PVTT_AB_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_PVTT_CD_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_P0V75_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_P1V2_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_P1V8_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_PVPP_AB_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_PVPP_CD_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_PVTT_AB_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_PVTT_CD_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_E1S0_P3V3_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_P1V2_STBY_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_P3V3_STBY_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_PMON_E1S0_P12V_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_PMON_P12V_STBY_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V85_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V8_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_AB_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_CD_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V85_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V8_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_AB_VOLT_V │ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_CD_VOLT_V
1b4138e
to
81b3174
Compare
@DelphineChiu has updated the pull request. You must reimport the pull request before landing. |
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Based on the discussion results of sensor naming rules, it is uniformly changed to BLAH. Unless there is a special case to distinguish the main/second source, it will be displayed as 'BLAH_'. |
This pull request has been merged in 8b79345. |
Description:
Motivation:
Note:
Test Plan:
Test Log:
# busctl tree xyz.openbmc_project.PLDM | grep WAILUA_FALLS_SLOT_1_ | wc -l 67# busctl tree xyz.openbmc_project.PLDM | grep WAILUA_FALLS_SLOT_1_root@bmc:
│ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_PMON_E1S_0_P12V_CURR_A
│ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_PMON_P12V_STBY_CURR_A
│ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V85_CURR_A
│ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V8_CURR_A
│ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_AB_CURR_A
│ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_CD_CURR_A
│ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V85_CURR_A
│ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V8_CURR_A
│ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_AB_CURR_A
│ │ ├─ /xyz/openbmc_project/sensors/current/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_CD_CURR_A
│ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_PMON_E1S_0_P12V_PWR_W
│ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_PMON_P12V_STBY_PWR_W
│ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V85_PWR_W
│ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V8_PWR_W
│ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_AB_PWR_W
│ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_CD_PWR_W
│ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V85_PWR_W
│ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V8_PWR_W
│ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_AB_PWR_W
│ │ ├─ /xyz/openbmc_project/sensors/power/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_CD_PWR_W
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC1_DIMM_A_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC1_DIMM_B_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC1_DIMM_C_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC1_DIMM_D_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC2_DIMM_A_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC2_DIMM_B_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC2_DIMM_C_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_ASIC2_DIMM_D_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_CXL1_CNTR_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_CXL2_CNTR_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_E1S_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_INLET_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V85_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V8_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_AB_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_CD_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V85_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V8_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_AB_TEMP_C
│ │ ├─ /xyz/openbmc_project/sensors/temperature/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_CD_TEMP_C
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_P0V75_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_P1V2_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_P1V8_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_PVPP_AB_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_PVPP_CD_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_PVTT_AB_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC1_PVTT_CD_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_P0V75_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_P1V2_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_P1V8_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_PVPP_AB_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_PVPP_CD_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_PVTT_AB_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_ASIC2_PVTT_CD_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_E1S_0_P3V3_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_P1V2_STBY_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_ADC_P3V3_STBY_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_PMON_E1S_0_P12V_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_PMON_P12V_STBY_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V85_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_P0V8_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_AB_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC1_PVDDQ_CD_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V85_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_P0V8_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_AB_VOLT_V
│ ├─ /xyz/openbmc_project/sensors/voltage/WAILUA_FALLS_SLOT_1_WF_VR_ASIC2_PVDDQ_CD_VOLT_V