Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url zoom, A fix for issue #1108 #1170

Closed
wants to merge 3 commits into from
Closed

Conversation

voscarmv
Copy link
Contributor

@voscarmv voscarmv commented Oct 24, 2023

Description

A fix for issue #1108:

For URLs with an object id such as rapideditor.org/rapid#id=w1204555438 users must pres Z to zoom into the object with id w1204555438

This fix zooms to the object automatically once the map is loaded.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • [✅] 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

#1108

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • 👍 yes
  • [✅] 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • [✅] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@voscarmv
Copy link
Contributor Author

voscarmv commented Oct 24, 2023

Builds fail on github but it works well on my local environment

image

@Bonkles
Copy link
Contributor

Bonkles commented Oct 24, 2023

Ah super quick @voscarmv you will need to run the code linter locally- npm run lint. I didn't cover this- my fault!

If you click into the test failures above, you will see that the linter is unhappy about some of your code formatting. Try to resolve the issues and update the PR branch once you're satisfied.

Incidentally, VSCode should give you a hint in the 'Problems' pane of the console, any errors will be called out there pretty clearly.

Try it for yourself- take any string and change it from double to singlequote- you should see something like:

image

@voscarmv
Copy link
Contributor Author

Ah super quick @voscarmv you will need to run the code linter locally- npm run lint. I didn't cover this- my fault!

If you click into the test failures above, you will see that the linter is unhappy about some of your code formatting. Try to resolve the issues and update the PR branch once you're satisfied.

Incidentally, VSCode should give you a hint in the 'Problems' pane of the console, any errors will be called out there pretty clearly.

Try it for yourself- take any string and change it from double to singlequote- you should see something like:

image

Got it @Bonkles !

@voscarmv voscarmv mentioned this pull request Oct 25, 2023
19 tasks
@voscarmv
Copy link
Contributor Author

@Bonkles I made a clean fork and a new PR with all linter issues fixed if you want to check it out: #1173

@bhousel
Copy link
Contributor

bhousel commented Oct 25, 2023

moved to #1173

@bhousel bhousel closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants