Skip to content

Commit

Permalink
Configure the shared settings instance before anything else
Browse files Browse the repository at this point in the history
Summary: When configuring the shared app events instance before configuring settings, the settings app ID is nil because its info dictionary provider isn't configured yet. This change makes sure that settings is configured before all other types since so many components rely on it.

Reviewed By: jawwad

Differential Revision: D40694989

fbshipit-source-id: 620b50a58358ad09c4fc7829ec372bf3b82d3e6b
  • Loading branch information
samodom authored and facebook-github-bot committed Oct 26, 2022
1 parent e4e3b9d commit e37a12d
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ final class CoreKitConfigurator: CoreKitConfiguring {
}

func performConfiguration() {
configureSettings()
configureAccessToken()
configureAppEvents()
configureAppEventsConfigurationManager()
Expand All @@ -34,7 +35,6 @@ final class CoreKitConfigurator: CoreKitConfiguring {
configureInstrumentManager()
configureInternalUtility()
configureServerConfigurationManager()
configureSettings()
configureCloudBridge()

#if !os(tvOS)
Expand Down

0 comments on commit e37a12d

Please sign in to comment.