Skip to content

Commit

Permalink
Add xxhash as a dependency
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookincubator/zstrong#1008

This doesn't seem to be a new dependency, but build errors only recently started surfacing for OSS:
https://www.internalfb.com/sandcastle/workflow/3098476543635661395

Reviewed By: robertroeser

Differential Revision: D64120664

fbshipit-source-id: 64d6fa130fa41bcbb9a40003b3b02eed38123641
  • Loading branch information
paulcruz74 authored and facebook-github-bot committed Oct 11, 2024
1 parent 0ffc50b commit 0b58fb1
Show file tree
Hide file tree
Showing 3 changed files with 56 additions and 0 deletions.
40 changes: 40 additions & 0 deletions build/fbcode_builder/CMake/FindXxhash.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Copyright (c) Facebook, Inc. and its affiliates.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

#
# - Try to find Facebook xxhash library
# This will define
# Xxhash_FOUND
# Xxhash_INCLUDE_DIR
# Xxhash_LIBRARY
#

find_path(Xxhash_INCLUDE_DIR NAMES xxhash.h)

find_library(Xxhash_LIBRARY_RELEASE NAMES xxhash)

include(SelectLibraryConfigurations)
SELECT_LIBRARY_CONFIGURATIONS(Xxhash)

include(FindPackageHandleStandardArgs)
FIND_PACKAGE_HANDLE_STANDARD_ARGS(
Xxhash DEFAULT_MSG
Xxhash_LIBRARY Xxhash_INCLUDE_DIR
)

if (Xxhash_FOUND)
message(STATUS "Found xxhash: ${Xxhash_LIBRARY}")
endif()

mark_as_advanced(Xxhash_INCLUDE_DIR Xxhash_LIBRARY)
1 change: 1 addition & 0 deletions build/fbcode_builder/manifests/fbthrift
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ libsodium
wangle
zstd
mvfst
xxhash
# Thrift also depends on openssl but since the latter requires a platform-
# specific configuration we rely on the folly manifest to provide this
# dependency to avoid duplication.
Expand Down
15 changes: 15 additions & 0 deletions build/fbcode_builder/manifests/xxhash
Original file line number Diff line number Diff line change
@@ -1,5 +1,20 @@
[manifest]
name = xxhash

[download]
url = https://github.com/Cyan4973/xxHash/archive/refs/tags/v0.8.2.tar.gz
sha256 = baee0c6afd4f03165de7a4e67988d16f0f2b257b51d0e3cb91909302a26a79c4

[rpms]
xxhash-devel

[build.not(os=windows)]
builder = make
subdir = xxHash-0.8.2

[make.build_args]
all

[make.install_args]
install

0 comments on commit 0b58fb1

Please sign in to comment.