Skip to content

Commit

Permalink
Move experimental/symbolizer/{tool,test} to debugging/symbolizer
Browse files Browse the repository at this point in the history
Summary: tsia

Differential Revision: D59683961

fbshipit-source-id: 53bb2df85f6e1189143a57c88e0bf88fea3cd3da
  • Loading branch information
Gownta authored and facebook-github-bot committed Jul 13, 2024
1 parent 9a94129 commit 2d9c0a3
Show file tree
Hide file tree
Showing 25 changed files with 31 additions and 31 deletions.
4 changes: 2 additions & 2 deletions .github/scripts/bad_targets
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ root//folly/debugging/exception_tracer:exception_tracer
root//folly/debugging/exception_tracer:exception_tracer_callbacks
root//folly/debugging/exception_tracer:smart_exception_stack_trace_hooks
root//folly/debugging/exception_tracer:smart_exception_tracer
root//folly/debugging/symbolizer/tool:folly-addr2line
root//folly/debugging/symbolizer/tool:libFollySegFault.so
root//folly/docs/examples/folly:baton_demo
root//folly/docs/examples/folly:cancellation_callback_demo
root//folly/docs/examples/folly:cancellation_source_demo
Expand Down Expand Up @@ -37,8 +39,6 @@ root//folly/docs/examples/folly/hash:hash_demo
root//folly/docs/examples/folly/io:i_o_buf_demo
root//folly/experimental/io:async_io
root//folly/experimental/io:simple_async_io
root//folly/experimental/symbolizer/tool:folly-addr2line
root//folly/experimental/symbolizer/tool:libFollySegFault.so
root//folly/logging/example:example
root//folly/python:executor_lib
root//folly/python:fibers_lib
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ custom_unittest(
# custom_unittest(
# name = "gnu_debuglink_test_small_sigaltstack",
# command = [
# "folly/experimental/symbolizer/test/gnu_debuglink_test.sh",
# "folly/debugging/symbolizer/test/gnu_debuglink_test.sh",
# "$(location :small_sigaltstack_crash)",
# ],
# type = "json",
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@

#include <folly/Benchmark.h>
#include <folly/Range.h>
#include <folly/debugging/symbolizer/test/SymbolizerTestUtils.h>
#include <folly/experimental/symbolizer/Dwarf.h>
#include <folly/experimental/symbolizer/SymbolizedFrame.h>
#include <folly/experimental/symbolizer/Symbolizer.h>
#include <folly/experimental/symbolizer/test/SymbolizerTestUtils.h>
#include <folly/portability/GFlags.h>

#if FOLLY_HAVE_ELF && FOLLY_HAVE_DWARF
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

#include <folly/experimental/symbolizer/test/SignalHandlerTest.h>
#include <folly/debugging/symbolizer/test/SignalHandlerTest.h>

#include <folly/experimental/symbolizer/SignalHandler.h>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ TEST(StackTraceTest, TerseFileAndLineStackTracePrinterOutput) {
printer.println(addresses, 0);

// Match a sequence of file+line results that should appear as:
// ./folly/experimental/symbolizer/test/StackTraceTest.cpp:202
// ./folly/debugging/symbolizer/test/StackTraceTest.cpp:202
// or:
// (unknown)
boost::regex regex("((([^:]*:[0-9]*)|(\\(unknown\\)))\n)+");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@
#include <folly/Range.h>
#include <folly/ScopeGuard.h>
#include <folly/String.h>
#include <folly/debugging/symbolizer/test/SymbolizerTestUtils.h>
#include <folly/experimental/symbolizer/ElfCache.h>
#include <folly/experimental/symbolizer/SymbolizedFrame.h>
#include <folly/experimental/symbolizer/detail/Debug.h>
#include <folly/experimental/symbolizer/test/SymbolizerTestUtils.h>
#include <folly/portability/Filesystem.h>
#include <folly/portability/GTest.h>
#include <folly/portability/Unistd.h>
Expand Down Expand Up @@ -267,14 +267,14 @@ TEST(SymbolizerTest, InlineFunctionBasic) {
frames.frames[4],
"inlineA_lfind",
"folly::symbolizer::test::inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
"folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
kLineno_lfind);

expectFrameEq(
frames.frames[5],
"inlineB_inlineA_lfind",
"folly::symbolizer::test::inlineB_inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
"folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
kLineno_inlineA_lfind);

FrameArray<100> frames2;
Expand Down Expand Up @@ -314,13 +314,13 @@ TEST(SymbolizerTest, InlineFunctionWithoutEnoughFrames) {
limitedFrames[0],
"inlineB_inlineA_lfind",
"folly::symbolizer::test::inlineB_inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
"folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
kLineno_inlineA_lfind);
expectFrameEq(
limitedFrames[1],
"call_B_A_lfind",
"folly::symbolizer::test::call_B_A_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTest.cpp",
"folly/debugging/symbolizer/test/SymbolizerTest.cpp",
kLineno_inlineB_inlineA_lfind);
}

Expand All @@ -340,21 +340,21 @@ TEST(SymbolizerTest, InlineFunctionInLexicalBlock) {
frames.frames[4],
"inlineA_lfind",
"folly::symbolizer::test::inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
"folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
kLineno_lfind);

expectFrameEq(
frames.frames[5],
"inlineB_inlineA_lfind",
"folly::symbolizer::test::inlineB_inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
"folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
kLineno_inlineA_lfind);

expectFrameEq(
frames.frames[6],
"lexicalBlock_inlineB_inlineA_lfind",
"folly::symbolizer::test::lexicalBlock_inlineB_inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils.cpp",
"folly/debugging/symbolizer/test/SymbolizerTestUtils.cpp",
kLineno_inlineB_inlineA_lfind);

printFrames(frames);
Expand All @@ -377,7 +377,7 @@ TEST(SymbolizerTest, InlineFunctionInDifferentCompilationUnit) {
frames.frames[5],
"inlineLTO_inlineA_lfind",
"folly::symbolizer::test::inlineLTO_inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils.cpp",
"folly/debugging/symbolizer/test/SymbolizerTestUtils.cpp",
kLineno_inlineA_lfind);
}

Expand All @@ -397,14 +397,14 @@ TEST(SymbolizerTest, InlineClassMemberFunctionSameFile) {
frames.frames[4],
"inlineA_lfind",
"folly::symbolizer::test::inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
"folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
kLineno_lfind);

expectFrameEq(
frames.frames[5],
"memberInline_inlineA_lfind",
"folly::symbolizer::test::ClassSameFile::memberInline_inlineA_lfind() const",
"folly/experimental/symbolizer/test/SymbolizerTestUtils.cpp",
"folly/debugging/symbolizer/test/SymbolizerTestUtils.cpp",
kLineno_inlineA_lfind);
}

Expand All @@ -424,14 +424,14 @@ TEST(SymbolizerTest, StaticInlineClassMemberFunctionSameFile) {
frames.frames[4],
"inlineA_lfind",
"folly::symbolizer::test::inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
"folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
kLineno_lfind);

expectFrameEq(
frames.frames[5],
"staticMemberInline_inlineA_lfind",
"folly::symbolizer::test::ClassSameFile::staticMemberInline_inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils.cpp",
"folly/debugging/symbolizer/test/SymbolizerTestUtils.cpp",
kLineno_inlineA_lfind);
}

Expand All @@ -451,14 +451,14 @@ TEST(SymbolizerTest, InlineClassMemberFunctionInDifferentFile) {
frames.frames[4],
"inlineA_lfind",
"folly::symbolizer::test::inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
"folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
kLineno_lfind);

expectFrameEq(
frames.frames[5],
"memberInline_inlineA_lfind",
"folly::symbolizer::test::ClassDifferentFile::memberInline_inlineA_lfind() const",
"folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
"folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
kLineno_inlineA_lfind);
}

Expand All @@ -478,14 +478,14 @@ TEST(SymbolizerTest, StaticInlineClassMemberFunctionInDifferentFile) {
frames.frames[4],
"inlineA_lfind",
"folly::symbolizer::test::inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
"folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
kLineno_lfind);

expectFrameEq(
frames.frames[5],
"staticMemberInline_inlineA_lfind",
"folly::symbolizer::test::ClassDifferentFile::staticMemberInline_inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
"folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
kLineno_inlineA_lfind);
}

Expand Down Expand Up @@ -528,14 +528,14 @@ TEST(SymbolizerTest, InlineFunctionWithCache) {
frames.frames[4],
"inlineA_lfind",
"folly::symbolizer::test::inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
"folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
kLineno_lfind);

expectFrameEq(
frames.frames[5],
"inlineB_inlineA_lfind",
"folly::symbolizer::test::inlineB_inlineA_lfind()",
"folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
"folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
kLineno_inlineA_lfind);

FrameArray<100> frames2;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

#pragma once

#include <folly/experimental/symbolizer/test/SymbolizerTestUtils.h>
#include <folly/debugging/symbolizer/test/SymbolizerTestUtils.h>

extern "C" {
// Fwd declare instead of #include <stdlib.h> to minimize generated DWARF.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

#include <folly/experimental/symbolizer/test/SymbolizerTestUtils.h>
#include <folly/debugging/symbolizer/test/SymbolizerTestUtils.h>

// NOTE: To simplify generated DWARF keep #includes to a minimum.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ class ClassDifferentFile {
} // namespace symbolizer
} // namespace folly

#include <folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h>
#include <folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h>
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ def validate_folly_symbolizer(name, binary):
custom_unittest(
name = name,
command = [
"$(exe //folly/experimental/symbolizer/test:compare-addr2line.sh)",
"$(location //folly/experimental/symbolizer/tool:folly-addr2line)",
"$(exe //folly/debugging/symbolizer/test:compare-addr2line.sh)",
"$(location //folly/debugging/symbolizer/tool:folly-addr2line)",
"$(location //third-party-buck/platform010/build/llvm-fb/15:bin/llvm-addr2line)",
"$(location {})".format(binary),
],
Expand All @@ -121,7 +121,7 @@ def validate_symbolizer_dwp(name, binary):
custom_unittest(
name = name,
command = [
"$(exe //folly/experimental/symbolizer/test:symbolizer_dwp_compability.sh)",
"$(exe //folly/debugging/symbolizer/test:symbolizer_dwp_compability.sh)",
"$(location {})".format(binary),
"$(location {}[dwp])".format(binary),
config.get_build_mode(),
Expand Down
File renamed without changes.

0 comments on commit 2d9c0a3

Please sign in to comment.