Skip to content

Commit

Permalink
fix hangs in watchman oss ubuntu tests by excluding liblzma-dev
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookincubator/zstrong#1072

watchman oss tests on ubuntu are [hanging 2 hours on github and then failing](https://github.com/facebook/watchman/actions/runs/11989130985/job/33425158244), and locally show errors.

One clue was that tests worked locally on centos stream 9 and fedora 40, pointing to one or more of the ubuntu system packages being the trigger.

Turns out that having the ubuntu xz aka liblzma-dev system packages linked is triggering the issue on both ubuntu 22.04 and 24.04.  Disabled system packages for xz and for glog and libunwind that also bring in the xz system packages on ubuntu.

Why ubuntu's liblzma triggers this problem is unknown at this time.  This change seems to be an improvement in that we get test results, with two tests showing intermittent failutes on ubuntu-22.04 runs.

Reviewed By: ckwalsh

Differential Revision: D66446570

fbshipit-source-id: 8a631e51012c7b90e867268451fd023304039589
  • Loading branch information
ahornby authored and facebook-github-bot committed Nov 25, 2024
1 parent 87a0028 commit 764d4c4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion build/fbcode_builder/manifests/glog
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ HAVE_TR1_UNORDERED_SET=OFF
[homebrew]
glog

[debs]
# on ubuntu glog brings in liblzma-dev, which in turn breaks watchman tests
[debs.not(distro=ubuntu)]
libgoogle-glog-dev

[rpms.distro=fedora]
Expand Down
3 changes: 2 additions & 1 deletion build/fbcode_builder/manifests/libunwind
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ name = libunwind
libunwind-devel
libunwind

[debs]
# on ubuntu this brings in liblzma-dev, which in turn breaks watchman tests
[debs.not(distro=ubuntu)]
libunwind-dev

[download]
Expand Down
3 changes: 2 additions & 1 deletion build/fbcode_builder/manifests/xz
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
[manifest]
name = xz

[debs]
# ubuntu's package causes watchman's tests to hang
[debs.not(distro=ubuntu)]
liblzma-dev

[homebrew]
Expand Down

0 comments on commit 764d4c4

Please sign in to comment.