Skip to content

Commit

Permalink
enable bm_estimate_time to accept bm_max_secs
Browse files Browse the repository at this point in the history
Summary:
The previous one was falsely reverted.

Currently, if we enable `bm_estimate_time`, the max benchmark time is 5 seconds. We should allow users to increase it by tuning bm_max_secs

Differential Revision: D67281933

fbshipit-source-id: 9b18cf46da77549134566c62fe332d8d70d65ad0
  • Loading branch information
Zhijian Jiang authored and facebook-github-bot committed Dec 17, 2024
1 parent 75d3e3d commit 7f17656
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions folly/Benchmark.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -263,11 +263,11 @@ static std::pair<double, UserCounters> runBenchmarkGetNSPerIterationEstimate(
size_t actualTrials = 0;
const unsigned int estimateCount = to_integral(max(1.0, 5e+7 / estPerIter));
std::vector<TrialResultType> trialResults(FLAGS_bm_max_trials);
const auto maxRunTime = seconds(5);
const auto maxRunTime = seconds(max(5, FLAGS_bm_max_secs));
auto globalStart = high_resolution_clock::now();

// Run benchmark up to trial times with at least 0.5 sec each
// Or until we run out of alowed time (5sec)
// Or until we run out of allowed time (max(5, FLAGS_bm_max_secs))
for (size_t tryId = 0; tryId < FLAGS_bm_max_trials; tryId++) {
detail::TimeIterData timeIterData = fun(estimateCount);
auto nsecs = duration_cast<nanoseconds>(timeIterData.duration);
Expand Down

0 comments on commit 7f17656

Please sign in to comment.