Skip to content

Commit

Permalink
Remove is_buck2() calls from folly/debugging/symbolizer/test/validate…
Browse files Browse the repository at this point in the history
…_folly_symbolizer.bzl

Summary:
buck1 is declared dead, is_buck2() checks will always return true. We can statically eliminate
these calls and associated conditional checks. folly/debugging/symbolizer/test/validate_folly_symbolizer.bzl was codemodded with libcst.

Reviewed By: dtolnay

Differential Revision: D63295980

fbshipit-source-id: ac669ed133eadd5989343fde812fe3374fbe4628
  • Loading branch information
Andrew Krieger authored and facebook-github-bot committed Sep 24, 2024
1 parent 11f0c9e commit 9c94307
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ load("@fbcode_macros//build_defs:config.bzl", "config")
load("@fbcode_macros//build_defs:cpp_library.bzl", "cpp_library")
load("@fbcode_macros//build_defs:cpp_unittest.bzl", "cpp_unittest")
load("@fbcode_macros//build_defs:custom_unittest.bzl", "custom_unittest")
load("@fbsource//tools/build_defs/buck2:is_buck2.bzl", "is_buck2")

SPLIT_DWARF_FLAGS = {
"none": ["-gno-split-dwarf"],
Expand Down Expand Up @@ -32,7 +31,7 @@ def customized_unittest(
for dwarf_size in available_dwarf_sizes:
for split_dwarf_option in avilable_split_dwarf_keys:
# buck2 doesn't support split version yet.
if split_dwarf_option == "none" or split_dwarf_option == "single_inlining" or not is_buck2():
if split_dwarf_option == "none" or split_dwarf_option == "single_inlining":
for use_aaranges in [False, True]:
cpp_library(
name = "symbolizer_test_utils_" + dwarf_version +
Expand Down

0 comments on commit 9c94307

Please sign in to comment.