Skip to content

Commit

Permalink
Mark targets that are known to be broken in oss
Browse files Browse the repository at this point in the history
Summary:
This enumerates what needs to be fixed, and gets us to a clean build
point so OSS buck2 builds can be made blocking.

Reviewed By: bigfootjon

Differential Revision: D64738941

fbshipit-source-id: 9241eb969593a05bd8c9ba3b1a27b5dd3d682b96
  • Loading branch information
ckwalsh authored and facebook-github-bot committed Oct 23, 2024
1 parent 772ef3e commit c5d60dc
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 0 deletions.
1 change: 1 addition & 0 deletions folly/compression/test/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ cpp_unittest(
srcs = ["CompressionTest.cpp"],
headers = [],
supports_static_listing = False,
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
"fbsource//third-party/zstd:zstd",
"//folly:random",
Expand Down
1 change: 1 addition & 0 deletions folly/debugging/symbolizer/test/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ cpp_binary(
"-g",
],
},
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
":symbolizer_test_utils_dwarf4_dwarf32_noaaranges",
"//folly:benchmark",
Expand Down
2 changes: 2 additions & 0 deletions folly/debugging/symbolizer/test/validate_folly_symbolizer.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def customized_unittest(
(["-gdwarf-aranges"] if use_aaranges else []) +
extra_compiler_flags,
modular_headers = False,
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
private_linker_flags = [
"--emit-relocs", # makes linker ignore `--strip-debug-*` flags
],
Expand All @@ -76,6 +77,7 @@ def customized_unittest(
linker_flags = [
"--emit-relocs", # makes linker ignore `--strip-debug-*` flags
],
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
":symbolizer_test_utils_" + dwarf_version +
("_dwarf{}".format(dwarf_size)) +
Expand Down
1 change: 1 addition & 0 deletions folly/debugging/symbolizer/tool/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ cpp_binary(
}),
),
],
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
"//folly:range",
"//folly/experimental/symbolizer:signal_handler",
Expand Down
1 change: 1 addition & 0 deletions folly/memory/test/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ cpp_unittest(
"not_null_test.cpp",
],
supports_static_listing = False,
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
"//folly/memory:not_null",
"//folly/portability:gtest",
Expand Down
5 changes: 5 additions & 0 deletions folly/python/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ cpp_library(
],
# TODO(T36778537): Cython-generated `*_api.h` headers aren't modular.
modular_headers = False,
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
":import",
],
Expand Down Expand Up @@ -118,6 +119,7 @@ cpp_library(
],
# TODO(T36778537): Cython-generated `*_api.h` headers aren't modular.
modular_headers = False,
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
exported_deps = [
"fbsource//third-party/python:python", # Python.h
":asyncio_executor",
Expand Down Expand Up @@ -148,6 +150,7 @@ cpp_library(
],
# TODO(T36778537): Cython-generated `*_api.h` headers aren't modular.
modular_headers = False,
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
exported_deps = [
"fbsource//third-party/python:python", # Python.h
":asyncio_executor",
Expand Down Expand Up @@ -183,6 +186,7 @@ cpp_library(
],
# TODO(T36778537): Cython-generated `*_api.h` headers aren't modular.
modular_headers = False,
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
":import",
],
Expand Down Expand Up @@ -247,6 +251,7 @@ cpp_library(
],
# TODO(T36778537): Cython-generated `*_api.h` headers aren't modular.
modular_headers = False,
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
":import",
],
Expand Down
2 changes: 2 additions & 0 deletions folly/python/test/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ cpp_library(
name = "iobuf_test_utils",
srcs = ["IOBufTestUtils.cpp"],
headers = ["IOBufTestUtils.h"],
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
"//folly/python:iobuf_lib",
],
Expand Down Expand Up @@ -131,6 +132,7 @@ cpp_unittest(
srcs = [
"ErrorTest.cpp",
],
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
"fbsource//third-party/python:python",
"//folly:scope_guard",
Expand Down
5 changes: 5 additions & 0 deletions folly/test/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -1467,6 +1467,7 @@ cpp_binary(
name = "singleton_thread_local_overload.so",
srcs = ["SingletonThreadLocalTestOverload.cpp"],
dlopen_enabled = True,
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
"//folly:singleton_thread_local",
],
Expand All @@ -1479,6 +1480,7 @@ cpp_unittest(
resources = [
":singleton_thread_local_overload.so",
],
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
":singleton_thread_local_overload.so", # @manual
"//folly:singleton_thread_local",
Expand Down Expand Up @@ -1767,6 +1769,7 @@ cpp_binary(
srcs = ["ThreadLocalTestLib.cpp"],
headers = [],
dlopen_enabled = True,
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
"//folly:thread_local",
],
Expand All @@ -1779,6 +1782,7 @@ cpp_unittest(
resources = [
":thread_local_test_lib.so",
],
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
"//folly:memory",
"//folly:thread_local",
Expand Down Expand Up @@ -1976,6 +1980,7 @@ cpp_unittest(
"-T",
"$(location :linker-scripts)/SdtTest.lds",
],
target_compatible_with = ["fbcode//opensource/macros:broken-in-oss"],
deps = [
"//folly/debugging/symbolizer:elf",
"//folly/tracing:static_tracepoint",
Expand Down

0 comments on commit c5d60dc

Please sign in to comment.