correct the wrong comment for encodeZigZag #2072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yfeldblum has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@yfeldblum merged this pull request in b198808. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jun 21, 2024
Summary: The comment for encodeZigZag(x) is wrong. Should be encodeZigZag(x) == -2*x - 1, as encodeZigZag(-1) = 1 and encodeZigZag(-2) = 3 Closes facebook/folly#2046 X-link: facebook/folly#2072 Reviewed By: Gownta Differential Revision: D58789263 Pulled By: yfeldblum fbshipit-source-id: af4d16b606cdc39ec930f16218ebf53637a86815
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment for encodeZigZag(x) is wrong.
Should be encodeZigZag(x) == -2*x - 1, as
encodeZigZag(-1) = 1
and
encodeZigZag(-2) = 3
Closes #2046