fix path conversion to c-str in SSLSessionTest #2193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: On Windows, `boost::filesystem::path::c_str()` has type `wchar_t const*` and not `char const*`; passing the result to `SSLContext` members does not compile. Reviewed By: vitaut Differential Revision: D57167715
|
This pull request was exported from Phabricator. Differential Revision: D57167715 |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
May 9, 2024
Summary: X-link: facebook/folly#2193 On Windows, `boost::filesystem::path::c_str()` has type `wchar_t const*` and not `char const*`; passing the result to `SSLContext` members does not compile. Reviewed By: vitaut Differential Revision: D57167715 fbshipit-source-id: d3bb232ea00ca327bee1f93665de4380dcec6631
|
This pull request has been merged in 0f37766. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: On Windows,
boost::filesystem::path::c_str()has typewchar_t const*and notchar const*; passing the result toSSLContextmembers does not compile.Reviewed By: vitaut
Differential Revision: D57167715