Use cmake to generate folly-config.h #2206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bigfootjon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: I feel like I'm committing crimes by doing it this way Reviewed By: yfeldblum Differential Revision: D57442666 Pulled By: bigfootjon
facebook-github-bot
force-pushed
the
buck2/folly-config.h
branch
from
db04616 to
a173f8f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57442666 |
|
@bigfootjon merged this pull request in 1b6421f. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
May 17, 2024
Summary: I feel like I'm committing crimes by doing it this way X-link: facebook/folly#2206 Reviewed By: yfeldblum Differential Revision: D57442666 Pulled By: bigfootjon fbshipit-source-id: 1e3294a88ba28957ff2d5f15127b82cab00d16dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like I'm committing crimes by doing it this way