Replace usage of std::latch with folly::Latch #2262
Closed
+11
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D59985585 |
|
This pull request was exported from Phabricator. Differential Revision: D59985585 |
michel-slm
force-pushed
the
export-D59985585
branch
from
95c7d3e to
72b8919
Compare
michel-slm
added a commit
to michel-slm/folly
that referenced
this pull request
Jul 23, 2024
Summary: Pull Request resolved: facebook#2262 Reworking PR facebook#2073 - use `folly::Latch` instead of having to fix ungated use of `std::latch`, which breaks open source builds that are still using CMake since `CMAKE_CXX_STANDARD` is still set to `17` (and bumping it to `20` might mean having to stop supporting the default compiler on some enterprise distributions). Differential Revision: D59985585
Summary: Pull Request resolved: facebook#2262 Reworking PR facebook#2073 - use `folly::Latch` instead of having to fix ungated use of `std::latch`, which breaks open source builds that are still using CMake since `CMAKE_CXX_STANDARD` is still set to `17` (and bumping it to `20` might mean having to stop supporting the default compiler on some enterprise distributions). Differential Revision: D59985585
|
This pull request was exported from Phabricator. Differential Revision: D59985585 |
michel-slm
force-pushed
the
export-D59985585
branch
from
72b8919 to
7af5426
Compare
|
This pull request has been merged in c260af2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reworking PR #2073 - use
folly::Latchinstead of having to fix ungateduse of
std::latch, which breaks open source builds that are still usingCMake since
CMAKE_CXX_STANDARDis still set to17(and bumping it to20might mean having to stop supporting the default compiler on someenterprise distributions).
Differential Revision: D59985585