clearing bit utils #2301
Closed
clearing bit utils #2301
+616
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D63329499 |
|
This pull request was exported from Phabricator. Differential Revision: D63329499 |
DenisYaroshevskiy
added a commit
to DenisYaroshevskiy/folly
that referenced
this pull request
Sep 26, 2024
Summary: Pull Request resolved: facebook#2301 make_maskl make_maskr set_lzero set_lone set_rzero set_lone Simple utils that correctly handle corner cases, such as shift == 64. I looked at the assembly a bit, probably that's ok. For x86 I used bmi2 where was appropriate. Differential Revision: D63329499
DenisYaroshevskiy
force-pushed
the
export-D63329499
branch
from
d469875 to
b3e03e1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63329499 |
DenisYaroshevskiy
force-pushed
the
export-D63329499
branch
from
b3e03e1 to
bef767c
Compare
DenisYaroshevskiy
added a commit
to DenisYaroshevskiy/folly
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#2301 make_maskl make_maskr set_lzero set_lone set_rzero set_lone Simple utils that correctly handle corner cases, such as shift == 64. I looked at the assembly a bit, probably that's ok. For x86 I used bmi2 where was appropriate. Differential Revision: D63329499
DenisYaroshevskiy
force-pushed
the
export-D63329499
branch
from
bef767c to
411d484
Compare
DenisYaroshevskiy
added a commit
to DenisYaroshevskiy/folly
that referenced
this pull request
Sep 27, 2024
Summary: Pull Request resolved: facebook#2301 n_least_significant_bits n_most_significant_bits clear_n_least_significant_bits set_n_least_significant_bits clear_n_most_significant_bits set_n_most_significant_bits Simple utils that correctly handle corner cases, such as shift == 64. I looked at the assembly a bit, probably that's ok. For x86 I used bmi2 where was appropriate. Differential Revision: D63329499
|
This pull request was exported from Phabricator. Differential Revision: D63329499 |
Summary: previous version of simd contains was rolled back because of no c++17 support. This should hopefully rectify that. Differential Revision: D63635013
|
This pull request was exported from Phabricator. Differential Revision: D63329499 |
DenisYaroshevskiy
force-pushed
the
export-D63329499
branch
from
411d484 to
989b068
Compare
DenisYaroshevskiy
added a commit
to DenisYaroshevskiy/folly
that referenced
this pull request
Oct 1, 2024
Summary: Pull Request resolved: facebook#2301 n_least_significant_bits n_most_significant_bits clear_n_least_significant_bits set_n_least_significant_bits clear_n_most_significant_bits set_n_most_significant_bits Simple utils that correctly handle corner cases, such as shift == 64. I looked at the assembly a bit, probably that's ok. For x86 I used bmi2 where was appropriate. Reviewed By: Gownta Differential Revision: D63329499
Summary: Pull Request resolved: facebook#2301 n_least_significant_bits n_most_significant_bits clear_n_least_significant_bits set_n_least_significant_bits clear_n_most_significant_bits set_n_most_significant_bits Simple utils that correctly handle corner cases, such as shift == 64. I looked at the assembly a bit, probably that's ok. For x86 I used bmi2 where was appropriate. Reviewed By: Gownta Differential Revision: D63329499
DenisYaroshevskiy
force-pushed
the
export-D63329499
branch
from
989b068 to
6c48261
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63329499 |
DenisYaroshevskiy
pushed a commit
to DenisYaroshevskiy/folly
that referenced
this pull request
Oct 1, 2024
Summary: Pull Request resolved: facebook#2301 n_least_significant_bits n_most_significant_bits clear_n_least_significant_bits set_n_least_significant_bits clear_n_most_significant_bits set_n_most_significant_bits Simple utils that correctly handle corner cases, such as shift == 64. I looked at the assembly a bit, probably that's ok. For x86 I used bmi2 where was appropriate. Differential Revision: D63329499 Reviewed By: Gownta
|
This pull request has been merged in c669175. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 1, 2024
Summary: X-link: facebook/folly#2301 n_least_significant_bits n_most_significant_bits clear_n_least_significant_bits set_n_least_significant_bits clear_n_most_significant_bits set_n_most_significant_bits Simple utils that correctly handle corner cases, such as shift == 64. I looked at the assembly a bit, probably that's ok. For x86 I used bmi2 where was appropriate. Reviewed By: Gownta Differential Revision: D63329499 fbshipit-source-id: 920d3fe597c63e8ef6e0319ba81c8fc5f3aa5c0e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
make_maskl
make_maskr
set_lzero
set_lone
set_rzero
set_lone
Simple utils that correctly handle corner cases, such as shift == 64.
I looked at the assembly a bit, probably that's ok.
For x86 I used bmi2 where was appropriate.
Differential Revision: D63329499