change contains interface to be more restrictive #2309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D63979345 |
DenisYaroshevskiy
added a commit
to DenisYaroshevskiy/folly
that referenced
this pull request
Oct 7, 2024
Summary: previous interface allowed for implicit conversions. So it so happens that the user would have to guard against it. I think I better guard here. Differential Revision: D63979345
DenisYaroshevskiy
force-pushed
the
export-D63979345
branch
from
0bdefd7 to
4dd45e2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63979345 |
DenisYaroshevskiy
added a commit
to DenisYaroshevskiy/folly
that referenced
this pull request
Oct 7, 2024
Summary: previous interface allowed for implicit conversions. So it so happens that the user would have to guard against it. I think I better guard here. Differential Revision: D63979345
DenisYaroshevskiy
force-pushed
the
export-D63979345
branch
from
4dd45e2 to
59978fe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63979345 |
DenisYaroshevskiy
added a commit
to DenisYaroshevskiy/folly
that referenced
this pull request
Oct 7, 2024
Summary: previous interface allowed for implicit conversions. So it so happens that the user would have to guard against it. I think I better guard here. Differential Revision: D63979345
DenisYaroshevskiy
force-pushed
the
export-D63979345
branch
from
59978fe to
634d1b5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63979345 |
DenisYaroshevskiy
added a commit
to DenisYaroshevskiy/folly
that referenced
this pull request
Oct 8, 2024
Summary: previous interface allowed for implicit conversions. So it so happens that the user would have to guard against it. I think I better guard here. Differential Revision: D63979345
DenisYaroshevskiy
force-pushed
the
export-D63979345
branch
from
634d1b5 to
be28dc4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63979345 |
DenisYaroshevskiy
added a commit
to DenisYaroshevskiy/folly
that referenced
this pull request
Oct 9, 2024
Summary: previous interface allowed for implicit conversions. So it so happens that the user would have to guard against it. I think I better guard here. Reviewed By: yfeldblum Differential Revision: D63979345
DenisYaroshevskiy
force-pushed
the
export-D63979345
branch
from
be28dc4 to
9d1fcf4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63979345 |
Summary: previous interface allowed for implicit conversions. So it so happens that the user would have to guard against it. I think I better guard here. Reviewed By: yfeldblum Differential Revision: D63979345
DenisYaroshevskiy
force-pushed
the
export-D63979345
branch
from
9d1fcf4 to
13de225
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63979345 |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 10, 2024
Summary: X-link: facebook/folly#2309 previous interface allowed for implicit conversions. So it so happens that the user would have to guard against it. I think I better guard here. Reviewed By: yfeldblum Differential Revision: D63979345 fbshipit-source-id: dacc8037172467f308e81a147cdbe223b838da60
|
This pull request has been merged in df3fdab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
previous interface allowed for implicit conversions.
So it so happens that the user would have to guard against it.
I think I better guard here.
Differential Revision: D63979345