]: replace some usings with inheritance #2311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D64177693 |
DenisYaroshevskiy
added a commit
to DenisYaroshevskiy/folly
that referenced
this pull request
Oct 11, 2024
Summary: The name get's a little long in error messages, inheritance will help with that Reviewed By: yfeldblum Differential Revision: D64177693
DenisYaroshevskiy
force-pushed
the
export-D64177693
branch
from
52f8969 to
5457199
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64177693 |
DenisYaroshevskiy
added a commit
to DenisYaroshevskiy/folly
that referenced
this pull request
Oct 14, 2024
Summary: The name get's a little long in error messages, inheritance will help with that Reviewed By: yfeldblum Differential Revision: D64177693
DenisYaroshevskiy
force-pushed
the
export-D64177693
branch
from
5457199 to
2cb10ef
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64177693 |
Summary: In asan mode we should still check that the user didn't provide us invalid addresses. Reviewed By: yfeldblum Differential Revision: D64039159
Summary: marking noinline functions as noexcept to help compiler optimizations. I didn't see effect in the microbenchmarks, but should be at least not worse. Reviewed By: yfeldblum Differential Revision: D64046213
Summary: The name get's a little long in error messages, inheritance will help with that Reviewed By: yfeldblum Differential Revision: D64177693
DenisYaroshevskiy
force-pushed
the
export-D64177693
branch
from
2cb10ef to
b1659a0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64177693 |
|
This pull request has been merged in b293f9e. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Oct 14, 2024
Summary: X-link: facebook/folly#2311 The name get's a little long in error messages, inheritance will help with that Reviewed By: yfeldblum Differential Revision: D64177693 fbshipit-source-id: f0fd234f5deda25acfcc9252ff0c6c51f9c147e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The name get's a little long in error messages, inheritance will help with that
Differential Revision: D64177693