] chage comment #2342
Closed
] chage comment #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D66307350 |
Summary: I found "we don't trust the top bit" comment confusing. What I believe is happening, is that tag could be 0 for a non-zero element. And then things would break. As a consequence the code also relies on top bit being 1 for set values. Differential Revision: D66307350
DenisYaroshevskiy
force-pushed
the
export-D66307350
branch
from
bc8e202 to
636a897
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66307350 |
|
This pull request has been merged in ec6d9c9. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Nov 22, 2024
Summary: X-link: facebook/folly#2342 I found "we don't trust the top bit" comment confusing. What I believe is happening, is that tag could be 0 for a non-zero element. And then things would break. As a consequence the code also relies on top bit being 1 for set values. Reviewed By: Gownta Differential Revision: D66307350 fbshipit-source-id: 6e6cd2613098493c1414fdf9419f7f54ed11c8bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I found "we don't trust the top bit" comment confusing.
What I believe is happening, is that tag could be 0 for a non-zero element.
And then things would break.
As a consequence the code also relies on top bit being 1 for set values.
Differential Revision: D66307350