Skip to content

Commit

Permalink
Add optional logging of stacktrace in case of a FAILed image load
Browse files Browse the repository at this point in the history
Reviewed By: erikandre, kartavya-ramnani

Differential Revision: D63725366

fbshipit-source-id: f5c3a605dd2e62fe932b06b853cc761740ad1aad
  • Loading branch information
Artem Kholodnyi authored and facebook-github-bot committed Oct 3, 2024
1 parent fe96e94 commit 2582448
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ class ImagePerfData(
val intermediateImageSetTimes: List<Pair<String, Long>>,
val newIntermediateImageSetPointAvailable: Boolean,
val errorMessageOnFailure: String?,
val errorStacktraceStringOnFailure: String?,
val errorCodeOnFailure: Int?,
val densityDpiOnSuccess: Int?,
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ open class ImagePerfLoggingState(val infra: ImageRenderingInfra) {
var startupStatusOnVisible: String? = null

var errorMessageOnFailure: String? = null
var errorStacktraceStringOnFailure: String? = null
var errorCodeOnFailure: Int? = null

var densityDpiOnSuccess: Int? = null
Expand All @@ -51,6 +52,7 @@ open class ImagePerfLoggingState(val infra: ImageRenderingInfra) {
startupStatusOnVisible = null

errorMessageOnFailure = null
errorStacktraceStringOnFailure = null
errorCodeOnFailure = null

densityDpiOnSuccess = null
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ class ImagePerfState(infra: ImageRenderingInfra) : ImagePerfLoggingState(infra)
intermediateImageSetTimes.toList(),
newIntermediateImageSetPointAvailable,
errorMessageOnFailure,
errorStacktraceStringOnFailure,
errorCodeOnFailure,
densityDpiOnSuccess,
)
Expand Down

0 comments on commit 2582448

Please sign in to comment.