fix linux and macOS build

Summary:
fix linux and macOS build

linux and mac build was failing:
   * gcc and xcode hide std::chrono::years if C++ 20 mode not set.  Disable the affected test in this case
   * same with std::latch, also disable the affected test in this case

macOS build was failing with:

   * missing header includes, added them

macOS test run was failing with:
   * libcpp exception text has changed from "with" to "due to" which was breaking ExceptionTest.cpp, update the expectation to cover both.
   * FileUtilDetail.cpp was only enabling custom temp dir on linux, breaking FileUtilTest.cpp.  Enable custom temp dir for non-windows (i.e. mac and other unix) to fix it.

X-link: facebook/folly#2073

Reviewed By: xavierd

Differential Revision: D49931137

Pulled By: Orvid

fbshipit-source-id: 58830a637e73375eb648c5897dd8a1e5e479c657

third-party/folly/src/folly/concurrency/test/ConcurrentHashMapTest.cpp

@@ -17,19 +17,24 @@
 #include <folly/concurrency/ConcurrentHashMap.h>
 
 #include <atomic>
-#include <latch>
 #include <limits>
 #include <memory>
 #include <thread>
 #include <vector>
 
+#include <folly/Portability.h>
 #include <folly/Traits.h>
 #include <folly/container/test/TrackingTypes.h>
 #include <folly/hash/Hash.h>
 #include <folly/portability/GFlags.h>
 #include <folly/portability/GTest.h>
 #include <folly/test/DeterministicSchedule.h>
 
+#if FOLLY_CPLUSPLUS >= 202002L
+// std::latch becomes visible in C++20 mode
+#include <latch>
+#endif
+
 using namespace folly::test;
 using namespace folly;
 using namespace std;
@@ -1135,6 +1140,8 @@ TYPED_TEST_P(ConcurrentHashMapTest, ConcurrentInsertClear) {
 }
 
 TYPED_TEST_P(ConcurrentHashMapTest, StressTestReclamation) {
+// This needs C++20 for std::latch.
+#if FOLLY_CPLUSPLUS >= 202002L
   // Create a map where we keep reclaiming a lot of objects that are linked to
   // one node.
 
@@ -1178,6 +1185,7 @@ TYPED_TEST_P(ConcurrentHashMapTest, StressTestReclamation) {
   for (auto& t : threads) {
     join;
   }
+#endif
 }
 
 REGISTER_TYPED_TEST_SUITE_P(

third-party/folly/src/folly/detail/FileUtilDetail.cpp

@@ -44,13 +44,13 @@ std::string getTemporaryFilePathStringWithoutTempDirectory(
 
 std::string getTemporaryFilePathStringWithTemporaryDirectory(
     const std::string& temporaryDirectory) {
-#if defined(__linux__) && !FOLLY_MOBILE
+#if !defined(_WIN32) && !FOLLY_MOBILE
   return (temporaryDirectory.back() == '/')
       ? (temporaryDirectory + std::string{"tempForAtomicWrite.XXXXXX"})
       : (temporaryDirectory + std::string{"/tempForAtomicWrite.XXXXXX"});
 #else
-  // The implementation currently, does not support any platform other than
-  // linux for temporary directory based atomic file writes.
+  // The implementation currently does not support win32 or mobile
+  // for temporary directory based atomic file writes.
   static_cast<void>(temporaryDirectory);
   assert(false);
 

third-party/folly/src/folly/lang/test/ExceptionTest.cpp

@@ -68,7 +68,7 @@ template <typename Ex>
 static std::string message_for_terminate_with(std::string const& what) {
   auto const name = folly::pretty_name<Ex>();
   std::string const p0 = "terminate called after throwing an instance of";
-  std::string const p1 = "terminating with uncaught exception of type";
+  std::string const p1 = "terminating (due to|with) uncaught exception of type";
   // clang-format off
   return
       folly::kIsGlibcxx ? p0 + " '" + name + "'\\s+what\\(\\):\\s+" + what :

third-party/folly/src/folly/stats/DigestBuilder.h

@@ -17,6 +17,7 @@
 #pragma once
 
 #include <memory>
+#include <vector>
 
 #include <folly/Memory.h>
 #include <folly/SpinLock.h>

third-party/folly/src/folly/test/ConstexprMathTest.cpp

@@ -16,6 +16,7 @@
 
 #include <folly/ConstexprMath.h>
 
+#include <array>
 #include <cmath>
 #include <limits>
 #include <type_traits>