Minor readability refactoring

Summary: Minor refactoring Reviewed By: iahs Differential Revision: D67545998 fbshipit-source-id: e4faedf4cf81ce5a4eed710c8388f0237327ec6b
facebook · Dec 21, 2024 · b45560b · b45560b
1 parent aabd163
commit b45560b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/third-party/thrift/src/thrift/compiler/generate/mstch_objects.h b/third-party/thrift/src/thrift/compiler/generate/mstch_objects.h
@@ -1179,11 +1179,7 @@ class mstch_field : public mstch_base {
         return item.second->get_integer() == action;
       }
     }
-    if (action == def && annotation->value()->get_map().size() == 0) {
-      return true;
-    }
-
-    return false;
+    return action == def && annotation->value()->get_map().empty();
   }
 
  protected:
@@ -1267,11 +1263,7 @@ class mstch_enum : public mstch_base {
         return item.second->get_integer() == action;
       }
     }
-    if (action == def && annotation->value()->get_map().size() == 0) {
-      return true;
-    }
-
-    return false;
+    return action == def && annotation->value()->get_map().empty();
   }
   mstch::node thrift_uri() { return enum_->uri(); }
 

diff --git a/third-party/thrift/src/thrift/compiler/generate/t_mstch_cpp2_generator.cc b/third-party/thrift/src/thrift/compiler/generate/t_mstch_cpp2_generator.cc
@@ -1162,8 +1162,7 @@ class cpp_mstch_type : public mstch_type {
       if (!next->is_container()) {
         continue;
       }
-      if (false) {
-      } else if (next->is_list()) {
+      if (next->is_list()) {
         queue.push(static_cast<const t_list*>(next)->get_elem_type());
       } else if (next->is_set()) {
         queue.push(static_cast<const t_set*>(next)->get_elem_type());