Skip to content

Commit

Permalink
Restrict build targets (#2191)
Browse files Browse the repository at this point in the history
Summary: Pull Request resolved: facebook/folly#2191

Test Plan: This brings us closer to CI passing on folly on OSS

Reviewed By: Orvid

Differential Revision: D57165673

Pulled By: bigfootjon

fbshipit-source-id: a4fe07d200bf7080ff2c045b5bdc21dea7f95ba5
  • Loading branch information
bigfootjon authored and facebook-github-bot committed May 14, 2024
1 parent a352f55 commit ca34cdc
Show file tree
Hide file tree
Showing 2 changed files with 50 additions and 1 deletion.
46 changes: 46 additions & 0 deletions third-party/folly/src/.github/scripts/bad_targets
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
# This is a list of bad targets that do not build in OSS. Ideally this list goes away
# with time.
root//folly/docs/examples/folly:baton_demo
root//folly/docs/examples/folly:cancellation_callback_demo
root//folly/docs/examples/folly:cancellation_source_demo
root//folly/docs/examples/folly:cancellation_token_demo
root//folly/docs/examples/folly:dynamic_converter_demo
root//folly/docs/examples/folly:dynamic_demo
root//folly/docs/examples/folly:executor_guide
root//folly/docs/examples/folly:file_demo
root//folly/docs/examples/folly:format_demo
root//folly/docs/examples/folly:function_demo
root//folly/docs/examples/folly:ipaddress_demo
root//folly/docs/examples/folly:likely_demo
root//folly/docs/examples/folly:map_util_demo
root//folly/docs/examples/folly:scope_guard_demo
root//folly/docs/examples/folly:scope_guard2_demo
root//folly/docs/examples/folly:scoped_event_base_thread_demo
root//folly/docs/examples/folly:scoped_event_base_thread2_demo
root//folly/docs/examples/folly:synchronized_demo
root//folly/docs/examples/folly/container:array_demo
root//folly/docs/examples/folly/dynamic:array_demo
root//folly/docs/examples/folly/dynamic:object_demo
root//folly/docs/examples/folly/experimental/coro:async_scope_demo
root//folly/docs/examples/folly/experimental/coro:cancellable_async_scope_demo
root//folly/docs/examples/folly/experimental/coro:detach_on_cancel_demo
root//folly/docs/examples/folly/experimental/coro:promise_demo
root//folly/docs/examples/folly/experimental/coro:retry_demo
root//folly/docs/examples/folly/experimental/coro:task_demo
root//folly/docs/examples/folly/experimental/coro:with_cancellation_demo
root//folly/docs/examples/folly/hash:hash_demo
root//folly/docs/examples/folly/io:i_o_buf_demo
root//folly/experimental/exception_tracer:exception_counter
root//folly/experimental/exception_tracer:exception_tracer
root//folly/experimental/exception_tracer:exception_tracer_callbacks
root//folly/experimental/exception_tracer:smart_exception_stack_trace_hooks
root//folly/experimental/exception_tracer:smart_exception_tracer
root//folly/experimental/io:async_io
root//folly/experimental/io:simple_async_io
root//folly/experimental/symbolizer/tool:folly-addr2line
root//folly/experimental/symbolizer/tool:libFollySegFault.so
root//folly/logging/example:example
root//folly/python:executor_lib
root//folly/python:fibers_lib
root//folly/python:iobuf_lib
root//folly/tool:benchmark_compare
5 changes: 4 additions & 1 deletion third-party/folly/src/.github/scripts/buck_build_and_test.sh
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

TARGETS_FILE=$(mktemp)
./buck2 targets //... | grep -F -v -f .github/scripts/bad_targets | grep -v test >"$TARGETS_FILE"

./buck2 build //... && ./buck2 test //...
./buck2 build @"$TARGETS_FILE"
# ./buck2 test @"$TARGETS_FILE"

0 comments on commit ca34cdc

Please sign in to comment.