Fix is selected noop (#3805)

facebook · Feb 2, 2023 · b70fe79 · b70fe79 · vercel · Feb 2, 2023
1 parent 60704c7
commit b70fe79
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/packages/lexical-react/src/useLexicalNodeSelection.ts b/packages/lexical-react/src/useLexicalNodeSelection.ts
@@ -40,9 +40,17 @@ export function useLexicalNodeSelection(
   );
 
   useEffect(() => {
-    return editor.registerUpdateListener(() => {
-      setIsSelected(isNodeSelected(editor, key));
+    let isMounted = true;
+    const unregister = editor.registerUpdateListener(() => {
+      if (isMounted) {
+        setIsSelected(isNodeSelected(editor, key));
+      }
     });
+
+    return () => {
+      isMounted = false;
+      unregister();
+    };
   }, [editor, key]);
 
   const setSelected = useCallback(