Addressed PR feedback for Unify implementations and deprecate @lexica…

…l/selection
facebook · Dec 5, 2024 · b8a43e4 · b8a43e4
1 parent 6113603
commit b8a43e4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 36 deletions.
diff --git a/packages/lexical-selection/src/index.ts b/packages/lexical-selection/src/index.ts
@@ -29,12 +29,11 @@ import {
   getStyleObjectFromCSS,
 } from './utils';
 
-export {
-  /** @deprecated moved to the lexical package */ $selectAll,
-} from 'lexical';
 export {
   /** @deprecated moved to the lexical package */ $cloneWithProperties,
+  /** @deprecated moved to the lexical package */ $selectAll,
 } from 'lexical';
+
 export {
   $addNodeStyle,
   $isAtNodeEnd,

diff --git a/packages/lexical-selection/src/range-selection.ts b/packages/lexical-selection/src/range-selection.ts
@@ -452,11 +452,6 @@ export function $moveCharacter(
   );
 }
 
-/**
- * @deprecated This function has been moved to the lexical package. Use the $selectAll function from the lexical package instead.
- */
-export {$selectAll} from 'lexical';
-
 /**
  * Returns the current value of a CSS property for Nodes, if set. If not set, it returns the defaultValue.
  * @param node - The node whose style value to get.

diff --git a/packages/lexical/src/LexicalUtils.ts b/packages/lexical/src/LexicalUtils.ts
@@ -1087,39 +1087,15 @@ export function isSelectAll(
 export function $selectAll(selection?: RangeSelection | null): RangeSelection {
   const root = $getRoot();
 
-  if (selection && $isRangeSelection(selection)) {
-    // Expand the existing RangeSelection
+  if ($isRangeSelection(selection)) {
     const anchor = selection.anchor;
     const focus = selection.focus;
     const anchorNode = anchor.getNode();
     const topParent = anchorNode.getTopLevelElementOrThrow();
     const rootNode = topParent.getParentOrThrow();
-    let firstNode = rootNode.getFirstDescendant();
-    let lastNode = rootNode.getLastDescendant();
-    let firstType: 'element' | 'text' = 'element';
-    let lastType: 'element' | 'text' = 'element';
-    let lastOffset = 0;
-
-    if ($isTextNode(firstNode)) {
-      firstType = 'text';
-    } else if (!$isElementNode(firstNode) && firstNode !== null) {
-      firstNode = firstNode.getParentOrThrow();
-    }
-
-    if ($isTextNode(lastNode)) {
-      lastType = 'text';
-      lastOffset = lastNode.getTextContentSize();
-    } else if (!$isElementNode(lastNode) && lastNode !== null) {
-      lastNode = lastNode.getParentOrThrow();
-    }
-
-    if (firstNode && lastNode) {
-      anchor.set(firstNode.getKey(), 0, firstType);
-      focus.set(lastNode.getKey(), lastOffset, lastType);
-    }
-
-    // Normalize and set the updated selection
-    $setSelection($normalizeSelection(selection));
+    anchor.set(rootNode.getKey(), 0, 'element');
+    focus.set(rootNode.getKey(), rootNode.getChildrenSize(), 'element');
+    $normalizeSelection(selection);
     return selection;
   } else {
     // Create a new RangeSelection