[lexical][TextNode] Feature: improve supporting multiple format on importDOM of TextNode #6087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2wheeh
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz and
ivailop7
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
acywatson
approved these changes
May 11, 2024
2wheeh
added a commit
to 2wheeh/lexical
that referenced
this pull request
May 12, 2024
zurfyx
pushed a commit
that referenced
this pull request
May 12, 2024
Sahejkm
pushed a commit
that referenced
this pull request
May 13, 2024
This was referenced Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when importing textNode from outside sources (or read-only mode),
convertTextFormatElementfunction is utilized fori,em,strong, ...However, this doesn't reflect their textFormat by style attributes unlike the handling of
spaninconvertSpanElement.So this PR extracts some logic from
convertSpanElementand applies it toconvertTextFormatElement.Test plan
Before
default.mov
After
2024-05-11.11.13.24.mov