You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't rely on TextNode when applying formatting for empty ParagraphNode
The initial issue was fixed in #6626, but the scenario with no TextNodes present was missed in the final version of pr
This is still not working for the styles - font size, font color, etc for the empty cells. Also when selecting the whole table and clicking on Bold, doesn't keep the toolbar button active, which if all cells have the applied said style should have active state.
Regarding text styles: ParagraphNode does not have properties to store them right now. We will need to add new properties in ParagraphNode and new create signals in Toolbar to process the action separately for table the same way it's done with formatting now. I'd rather do this in a separate pr as this is not a small change
Regarding text styles: ParagraphNode does not have properties to store them right now. We will need to add new properties in ParagraphNode and new create signals in Toolbar to process the action separately for table the same way it's done with formatting now. I'd rather do this in a separate pr as this is not a small change
CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.extended-testsRun extended e2e tests on a PR
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KatsiarynaDzibrova
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
facebook-github-bot
added
the
CLA Signed
Description
Don't rely on TextNode when applying formatting for empty ParagraphNode
The initial issue was fixed in #6626, but the scenario with no TextNodes present was missed in the final version of pr
Test plan
2 tests added