-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-yjs] Bug Fix: Add missing setLocalStateField method to ProviderAwareness type #6683
[lexical-yjs] Bug Fix: Add missing setLocalStateField method to ProviderAwareness type #6683
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests don't typecheck with this change because it adds a new required property where one wasn't needed before. It's unclear what the utility of this backwards incompatible change would be since this method isn't called anywhere in @lexical/yjs
Updated tests as well according new awareness contract. Nothing functional to test, so i replaced functional implementation with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The current type definition doesn't include the
setLocalStateField
method, which can lead to TypeScript errors when using this method and prevents proper code completion in IDEs. This change improves type safety and developer experience when working with thelexical-yjs
package.This PR adds the missing
setLocalStateField
method to theProviderAwareness
type in thelexical-yjs
package(ref). This method is present in the actual implementation of awareness providers but was not reflected in the TypeScript type definition.Test plan
Before
--
After
--