[lexical][lexical-list] Bug Fix: Retain indentation when list format is removed and reapplied

[SeaBa55]

Description

There is an issue in the lexical-list package where if the user removes the current applied list format, and then reapplies the same (or other) list format, indentation will not be retained. This results in a poor user experience with lists dropping indentation, for simply toggling the list format.

After some debugging, I saw that there was an attempt to handle this behavior within the $createListOrMerge method of formatList.ts, however, the indentation was not being applied in the newly added list nodes.

I found that the indentation would be applied to the new list nodes, only if the following invocations are applied after the list is attached to root:

listItem.setFormat(node.getFormatType());
listItem.setIndent(node.getIndent());

This PR does not close any issue. I realize I should have created an issue prior, and if the team requires this I can do so. Just let me know.

Before

removing_and_reapplying_list_format_looses_indentation_2024-09-28.mp4

After

removing_and_reapplying_list_format_keeps_indentation_2024-09-28.mp4

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lexical	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 11:06pm
lexical-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 11:06pm

[github-actions]

size-limit report 📦

Path	Size
lexical - cjs	29.91 KB (0%)
lexical - esm	29.72 KB (0%)
@lexical/rich-text - cjs	38.55 KB (0%)
@lexical/rich-text - esm	31.6 KB (0%)
@lexical/plain-text - cjs	37.09 KB (0%)
@lexical/plain-text - esm	28.92 KB (0%)
@lexical/react - cjs	40.29 KB (0%)
@lexical/react - esm	32.99 KB (0%)

[ivailop7]

LGTM, can I get a second look from someone please

[etrepum]

It seems like it's probably fine but I would be a lot happier about merging if there was at least one test to show that it does fix the given issue

[etrepum]

I can't repro any issues with the tests under react-beta locally, so maybe it's some kind of CI cache issue. Changes look good otherwise!