Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing github build: install only opam with apt #893

Closed
wants to merge 1 commit into from

Conversation

stroxler
Copy link
Contributor

Summary:
The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting dune from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59591828

stroxler added a commit that referenced this pull request Jul 10, 2024
Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59591828

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59591828

stroxler added a commit that referenced this pull request Jul 10, 2024
Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59591828

stroxler added a commit that referenced this pull request Jul 10, 2024
Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59591828

stroxler added a commit that referenced this pull request Jul 10, 2024
Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59591828

stroxler added a commit that referenced this pull request Jul 10, 2024
Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59591828

stroxler added a commit that referenced this pull request Jul 12, 2024
Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828
Summary:
Pull Request resolved: #893

The build in github is currently broken due to a dune version mismatch.

I think the problem is that our workflow is incorrectly getting `dune` from
an apt download rather than our opam switch; trying to see what happens if
we only apt install opam.

Differential Revision: D59591828
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59591828

@stroxler
Copy link
Contributor Author

I'm going to leave this up for now... the latest results seem to show that setup.py's PATH is somehow not making it all the way into the makefile logic behind make dev.

See these logs:
https://github.com/facebook/pyre-check/actions/runs/9911237956/job/27383440089?pr=893

It's pretty easy to see the path logged out from setup.py does not match what the Makefile sees, and this is why the Makefile can't find dune.

I'm pretty stumped about why; I know for sure that environment variables set at the top level do make it.

@stroxler stroxler closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants