Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A bunch of small changes in cmake. #289

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

igor-eremeev
Copy link

  1. Whole-archive was broken for gcc, it requires a closing block after the library.
  2. Pthread library was missing, linking was failing. Add it to cmake. I hope that cmake version bumping is ok. Please check windows cmake compilation after this, I don't have one to do it myself.
  3. Implement the simplest possible packaging task for redex-all into redex bundle.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@minjang
Copy link
Contributor

minjang commented Jan 2, 2018

@igor-eremeev Thanks for the suggestions!

  1. Thanks. I will test and incorporate your change.
  2. I will remove pthread instead (we'd like to minimize dependencies). Any reason why you want to bump CMake version?
  3. I was considering CPack for installation. Your approach seems interesting. I will consider it.

@igor-eremeev
Copy link
Author

igor-eremeev commented Jan 9, 2018

Thanks for reply!

Any reason why you want to bump CMake version?

No, it was only for simplicity of adding pthreads via this new shiny "Threads::Threads" thing, which is 3.1.0+. If pthreads are not an issue anymore, then just discard this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants