Single key operation #77

snickl · 2016-09-08T20:17:15Z

Small patch I've been using for a while now under Linux to avoid having to press Enter all the time.
It probably only works for Unix-like systems so I don't expect it to be merged per se, but maybe someone will be inspired to make it cross-platform.

ghost · 2016-09-08T20:17:43Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

modocache · 2016-09-08T20:28:08Z

Awesome, thanks! ❤️

I have a few questions that I'll post inline. Also, it looks like you'll need to rebase before these changes can be merged.

modocache · 2016-09-08T20:29:03Z

codemod/base.py

@@ -670,7 +671,7 @@ def _ask_about_patch(patch, editor, default_no):
            else:
                print ('Accept change (y = yes [default], n = no, e = edit, ' +
                       'A = yes to all, E = yes+edit)? '),
-            p = _prompt('yneEA', default=default_action)
+            p = _prompt('yneEAq', default=default_action)


Maybe I'm misunderstanding, but It seems like this and the sys.exit(0) call below could be split off into their own pull request. Splitting it out would make this easier to review/merge.

Agree, see #78

getch() implementation based on https://stackoverflow.com/questions/510357/python-read-a-single-character-from-the-user https://github.com/joeyespo/py-getch/blob/master/getch/getch.py

ghost · 2016-09-11T19:34:40Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

modocache · 2016-09-12T02:14:59Z

As per your comment above, let me try this on an OS X machine before merging. Give me a few days to get around to it -- thanks!

modocache reviewed Sep 8, 2016
View reviewed changes

snickl force-pushed the snickl branch 2 times, most recently from 88c5981 to 869f094 Compare September 11, 2016 19:18

Single key operation

0d2afa3

getch() implementation based on https://stackoverflow.com/questions/510357/python-read-a-single-character-from-the-user https://github.com/joeyespo/py-getch/blob/master/getch/getch.py

snickl force-pushed the snickl branch from 869f094 to 0d2afa3 Compare September 11, 2016 19:23

ghost added the CLA Signed label Sep 11, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Single key operation #77

Single key operation #77

snickl commented Sep 8, 2016

ghost commented Sep 8, 2016

modocache commented Sep 8, 2016

modocache Sep 8, 2016

snickl Sep 11, 2016

ghost commented Sep 11, 2016

modocache commented Sep 12, 2016

Single key operation #77

Are you sure you want to change the base?

Single key operation #77

Conversation

snickl commented Sep 8, 2016

ghost commented Sep 8, 2016

modocache commented Sep 8, 2016

modocache Sep 8, 2016

Choose a reason for hiding this comment

snickl Sep 11, 2016

Choose a reason for hiding this comment

ghost commented Sep 11, 2016

modocache commented Sep 12, 2016