Skip to content

Commit

Permalink
feat: Add new FileFormat::SST to toFileFormat and toString (#12137)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #12137

A new file format FileFormat::SST was introduced, but it was not added to these methods (toFileFormat and toString). Adding a new case statement to the toFileFormat function to return the FileFormat::SST value when the input string is "sst". The toString function is also updated to include a new case statement to return "sst" when the file format is FileFormat::SST. This will allow users to specify the file format as "sst" when working with Velox.

Reviewed By: kKPulla, sdruzkin, harsharastogi

Differential Revision: D68463647

fbshipit-source-id: e8af42237fa4fd278bbe46a28d1dfee2aefbaacc
  • Loading branch information
emilysun201309 authored and facebook-github-bot committed Jan 23, 2025
1 parent f910bb1 commit 5e238f4
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions velox/dwio/common/Options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ FileFormat toFileFormat(std::string_view s) {
return FileFormat::NIMBLE;
} else if (s == "orc") {
return FileFormat::ORC;
} else if (s == "sst") {
return FileFormat::SST;
}
return FileFormat::UNKNOWN;
}
Expand All @@ -61,6 +63,8 @@ std::string_view toString(FileFormat fmt) {
return "nimble";
case FileFormat::ORC:
return "orc";
case FileFormat::SST:
return "sst";
default:
return "unknown";
}
Expand Down

0 comments on commit 5e238f4

Please sign in to comment.