Add serializeColumn to PrestoVectorSerde

facebookincubator · Aug 21, 2024 · 9fdb4ae · 9fdb4ae
1 parent 4810dc3
commit 9fdb4ae
Show file tree

Hide file tree

Showing 7 changed files with 762 additions and 597 deletions.
diff --git a/velox/exec/Exchange.h b/velox/exec/Exchange.h
@@ -110,7 +110,7 @@ class Exchange : public SourceOperator {
   std::vector<std::unique_ptr<SerializedPage>> currentPages_;
   bool atEnd_{false};
   std::default_random_engine rng_{std::random_device{}()};
-  serializer::presto::PrestoVectorSerde::PrestoOptions options_;
+  serializer::presto::PrestoOptions options_;
 };
 
 } // namespace facebook::velox::exec
diff --git a/velox/exec/PartitionedOutput.cpp b/velox/exec/PartitionedOutput.cpp
@@ -54,7 +54,7 @@ BlockingReason Destination::advance(
   if (!current_) {
     current_ = std::make_unique<VectorStreamGroup>(pool_);
     auto rowType = asRowType(output->type());
-    serializer::presto::PrestoVectorSerde::PrestoOptions options;
+    serializer::presto::PrestoOptions options;
     options.compressionKind =
         OutputBufferManager::getInstance().lock()->compressionKind();
     options.minCompressionRatio = PartitionedOutput::minCompressionRatio();

diff --git a/velox/exec/SpillFile.cpp b/velox/exec/SpillFile.cpp
@@ -172,7 +172,7 @@ uint64_t SpillWriter::write(
   {
     MicrosecondTimer timer(&timeUs);
     if (batch_ == nullptr) {
-      serializer::presto::PrestoVectorSerde::PrestoOptions options = {
+      serializer::presto::PrestoOptions options = {
           kDefaultUseLosslessTimestamp, compressionKind_, true /*nullsFirst*/};
       batch_ = std::make_unique<VectorStreamGroup>(pool_);
       batch_->createStreamTree(

diff --git a/velox/exec/SpillFile.h b/velox/exec/SpillFile.h
@@ -267,7 +267,7 @@ class SpillReadFile {
   const uint32_t numSortKeys_;
   const std::vector<CompareFlags> sortCompareFlags_;
   const common::CompressionKind compressionKind_;
-  const serializer::presto::PrestoVectorSerde::PrestoOptions readOptions_;
+  const serializer::presto::PrestoOptions readOptions_;
   memory::MemoryPool* const pool_;
   folly::Synchronized<common::SpillStats>* const stats_;