Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Make TPCH dbgen text buffer size consistent with Presto Java (#1…
…2169) Summary: Changed text buffer size to be 300 MB for Velox's dbgen to match with Java Presto TPCH dbgen's text buffer size. The text buffer size is used in randomly generating offset and length to grab a chunk from the overall text for each row. This fixed the difference in the comment column for the tables in TPCH. Java: https://github.com/trinodb/tpch/blob/master/src/main/java/io/trino/tpch/TextPool.java#L35 ``` private static final int DEFAULT_TEXT_POOL_SIZE = 300 * 1024 * 1024; ``` C++: https://github.com/facebookincubator/velox/blob/main/velox/tpch/gen/DBGenIterator.cpp#L40 ``` load_dists( 10 * 1024 * 1024, &dbgenCtx); // 10 MB buffer size for text generation. ``` Resolves: prestodb/presto#24011 Pull Request resolved: #12169 Reviewed By: amitkdutta Differential Revision: D68653706 Pulled By: xiaoxmeng fbshipit-source-id: 635cc572bc79c33662e26124589992bcf6962830
- Loading branch information