Add support for parquet_writer_version session property
#10573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
reviewed
Jul 25, 2024
svm1
force-pushed
the
parq_rebase
branch
2 times, most recently
from
c422238 to
7c619ce
Compare
pedroerp
reviewed
Aug 1, 2024
velox/dwio/parquet/writer/Writer.cpp
Outdated
| auto parquetDataPageVersionString = | ||
| getParquetDataPageVersion(config, kParquetSessionDataPageVersion); | ||
|
|
||
| if (parquetDataPageVersionString == "PARQUET_1_0") { |
There was a problem hiding this comment.
maybe having a helper method with a switch to do the mapping, and throwing in case you get an invalid value instead of defaulting to v2?
parquetDataPageVersionString = toParquetDataPage(config);
There was a problem hiding this comment.
I see what you mean, but also realized I could just be doing the mapping in getParquetDataPageVersion() now, in combination with validation, and directly return a arrow::ParquetDataPageVersion value. Let me know if that looks ok.
svm1
force-pushed
the
parq_rebase
branch
2 times, most recently
from
ec3c78b to
3bec581
Compare
|
Reopened due to conflicts and rebasing - #11151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the Presto session property
parquet_writer_version, which is currently ignored by Velox, to toggle the parquet writer datapage version (V1 or V2). The value can be set as a session property or can be provided in the Hive config. Defaults to V2.