fix: Fix timestamp timezone in Parquet write #11949
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
reviewed
Dec 24, 2024
| @@ -645,6 +645,7 @@ struct WriterOptions { | |||
| std::function<std::unique_ptr<dwio::common::FlushPolicy>()> | |||
| flushPolicyFactory; | |||
|
|
|||
| std::string sessionTimezoneName; | |||
There was a problem hiding this comment.
Can we keep either sessionTimezoneName or sessionTimezone but not both?
There was a problem hiding this comment.
Removed 'sessionTimezone' as it is not in use. Thanks!
rui-mo
force-pushed
the
wip_fix_tz
branch
3 times, most recently
from
3071568 to
f5df57b
Compare
|
@Yuhta Above comment is fixed. Could you help review again? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session timezone is in 'QueryConfig' and cannot be accessed through
'sessionProperties' and 'hiveConfig'. This PR retrieves the session timezone
from the connector query context which stores the 'sessionTimezone' of the
query config in driver context.