Add Spark CAST(double/float as timestamp) #12041
Open
+82
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
Hey @rui-mo @jinchengchenghh , can help review this? Thanks! |
rui-mo
reviewed
Jan 10, 2025
There was a problem hiding this comment.
Perhaps also document this cast in https://github.com/facebookincubator/velox/blob/main/velox/docs/functions/spark/conversion.rst#cast-to-timestamp. Thanks.
| ToKind == TypeKind::TIMESTAMP) { | ||
| const auto castResult = | ||
| hooks_->castDoubleToTimestamp(static_cast<double>(inputRowValue)); | ||
| if (castResult.hasError()) { |
There was a problem hiding this comment.
Can we use 'setResultOrError'?
| Status::Invalid("Can not convert NaN or Infinity to timestamp")); | ||
| } | ||
| return Timestamp::fromMicrosNoError( | ||
| static_cast<int64_t>(value * Timestamp::kMicrosecondsInSecond)); |
There was a problem hiding this comment.
How is overflow handled? It looks different with the impl. of 'castIntToTimestamp'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Spark CAST (double/float as timestamp). The input value is treated as the
number of seconds since the epoch (1970-01-01 00:00:00 UTC).
Spark's implementation: https://github.com/apache/spark/blob/fd86f85e181fc2dc0f50a096855acf83a6cc5d9c/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala#L675