feat: Optimize PrestoBatchVectorSerializer [1/7]: Serialize FlatVectors #12060
+5,851
−4,675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwilfong
requested review from
assignUser and
majetideepak
as code owners
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68037258 |
✅ Deploy Preview for meta-velox canceled.
|
kevinwilfong
force-pushed
the
export-D68037258
branch
from
c06148e to
3164264
Compare
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Jan 10, 2025
…rs (facebookincubator#12060) Summary: Context: This is a series of diffs in which I reimplement PrestoBatchVectorSerializer to write directly to the output stream, rather than the indirect route it currently uses via VectorStreams. Reusing VectorStreams and much of the code for PrestoIterativeVectorSerializer prevented us from capturing all of the performance benefits of writing data in batches rather than row by row. These changes combined will speed up PrestoBatchVectorSerializer 2-3x (as measured in Presto queries and other use cases). In the final diff I will integrate the new serialization functions into PrestoBatchVectorSerializer's serialize function which will switch it to the new optimized writing path, therefore I will land these changes as a stack. In this diff: I provide the implementations for serializing FlatVectors. Differential Revision: D68037258
|
This pull request was exported from Phabricator. Differential Revision: D68037258 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Jan 10, 2025
…rs (facebookincubator#12060) Summary: Context: This is a series of diffs in which I reimplement PrestoBatchVectorSerializer to write directly to the output stream, rather than the indirect route it currently uses via VectorStreams. Reusing VectorStreams and much of the code for PrestoIterativeVectorSerializer prevented us from capturing all of the performance benefits of writing data in batches rather than row by row. These changes combined will speed up PrestoBatchVectorSerializer 2-3x (as measured in Presto queries and other use cases). In the final diff I will integrate the new serialization functions into PrestoBatchVectorSerializer's serialize function which will switch it to the new optimized writing path, therefore I will land these changes as a stack. In this diff: I provide the implementations for serializing FlatVectors. Differential Revision: D68037258
kevinwilfong
force-pushed
the
export-D68037258
branch
from
3164264 to
02b90c2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68037258 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Jan 11, 2025
…rs (facebookincubator#12060) Summary: Pull Request resolved: facebookincubator#12060 Context: This is a series of diffs in which I reimplement PrestoBatchVectorSerializer to write directly to the output stream, rather than the indirect route it currently uses via VectorStreams. Reusing VectorStreams and much of the code for PrestoIterativeVectorSerializer prevented us from capturing all of the performance benefits of writing data in batches rather than row by row. These changes combined will speed up PrestoBatchVectorSerializer 2-3x (as measured in Presto queries and other use cases). In the final diff I will integrate the new serialization functions into PrestoBatchVectorSerializer's serialize function which will switch it to the new optimized writing path, therefore I will land these changes as a stack. In this diff: I provide the implementations for serializing FlatVectors. Differential Revision: D68037258
kevinwilfong
force-pushed
the
export-D68037258
branch
from
02b90c2 to
e75e0f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68037258 |
…rs (facebookincubator#12060) Summary: Pull Request resolved: facebookincubator#12060 Context: This is a series of diffs in which I reimplement PrestoBatchVectorSerializer to write directly to the output stream, rather than the indirect route it currently uses via VectorStreams. Reusing VectorStreams and much of the code for PrestoIterativeVectorSerializer prevented us from capturing all of the performance benefits of writing data in batches rather than row by row. These changes combined will speed up PrestoBatchVectorSerializer 2-3x (as measured in Presto queries and other use cases). In the final diff I will integrate the new serialization functions into PrestoBatchVectorSerializer's serialize function which will switch it to the new optimized writing path, therefore I will land these changes as a stack. In this diff: I provide the implementations for serializing FlatVectors. Differential Revision: D68037258
kevinwilfong
force-pushed
the
export-D68037258
branch
from
e75e0f8 to
3c6c7e7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68037258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
This is a series of diffs in which I reimplement PrestoBatchVectorSerializer to write directly to the output stream,
rather than the indirect route it currently uses via VectorStreams. Reusing VectorStreams and much of the code
for PrestoIterativeVectorSerializer prevented us from capturing all of the performance benefits of writing data in
batches rather than row by row. These changes combined will speed up PrestoBatchVectorSerializer 2-3x (as
measured in Presto queries and other use cases).
In the final diff I will integrate the new serialization functions into PrestoBatchVectorSerializer's serialize
function which will switch it to the new optimized writing path, therefore I will land these changes as a stack.
In this diff:
I provide the implementations for serializing FlatVectors.
Differential Revision: D68037258