misc(fuzzer): Support custom result verifier with compare() API in window fuzzer #12148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68507422 |
✅ Deploy Preview for meta-velox canceled.
|
kgpai
approved these changes
Jan 22, 2025
| @@ -1052,27 +1052,6 @@ void AggregationFuzzer::Stats::print(size_t numIterations) const { | |||
| AggregationFuzzerBase::Stats::print(numIterations); | |||
| } | |||
|
|
|||
| namespace { | |||
| // Merges a vector of RowVectors into one RowVector. | |||
| RowVectorPtr mergeRowVectors( | |||
There was a problem hiding this comment.
Someone was just asking about a utility like this , thanks for moving it to fuzzer toolkit.
| frame); | ||
| customVerifierInitialized = true; | ||
| } catch (...) { | ||
| LOG(WARNING) << "Custom verifier initialization failed"; |
There was a problem hiding this comment.
nit: should we throw instead of just logging as a warning ?
There was a problem hiding this comment.
No, we intentionally create some illegal queries in window fuzzer to ensure they don't crash. In that case, the custom verifier initialization may throw, which is expected.
velox/exec/fuzzer/WindowFuzzer.cpp
Outdated
| LOG(INFO) << "Verified results against reference DB"; | ||
| } else if (referenceQueryRunner_->supportsVeloxVectorResults()) { | ||
| if (enableWindowVerification) { | ||
| auto prestoQueryRunner = |
There was a problem hiding this comment.
nit code under these if blocks is very similar, maybe we can move some of it to some common function ?
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Jan 23, 2025
…ndow fuzzer (facebookincubator#12148) Summary: The custom result verifiers of some functions provides a compare() API that can be used to compare the expected and actual results after certain transformation. This is needed for functions like `avg(interval) -> interval` because the result of this function can have a small precision error that should be tolerated. However, the window fuzzer used to only support the verify() API of custom result verifiers. This diff makes the window fuzzer to use the compare() API as well when available. Reviewed By: kgpai Differential Revision: D68507422
kagamiori
force-pushed
the
export-D68507422
branch
from
bca1f6c to
cf232ec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68507422 |
kagamiori
added a commit
to kagamiori/velox
that referenced
this pull request
Jan 23, 2025
…ndow fuzzer (facebookincubator#12148) Summary: The custom result verifiers of some functions provides a compare() API that can be used to compare the expected and actual results after certain transformation. This is needed for functions like `avg(interval) -> interval` because the result of this function can have a small precision error that should be tolerated. However, the window fuzzer used to only support the verify() API of custom result verifiers. This diff makes the window fuzzer to use the compare() API as well when available. Reviewed By: kgpai Differential Revision: D68507422
kagamiori
force-pushed
the
export-D68507422
branch
from
cf232ec to
ea3116c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68507422 |
…ndow fuzzer (facebookincubator#12148) Summary: The custom result verifiers of some functions provides a compare() API that can be used to compare the expected and actual results after certain transformation. This is needed for functions like `avg(interval) -> interval` because the result of this function can have a small precision error that should be tolerated. However, the window fuzzer used to only support the verify() API of custom result verifiers. This diff makes the window fuzzer to use the compare() API as well when available. Reviewed By: kgpai Differential Revision: D68507422
kagamiori
force-pushed
the
export-D68507422
branch
from
ea3116c to
0882dd9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68507422 |
|
This pull request has been merged in 419de77. |
|
Conbench analyzed the 0 benchmark runs that triggered this notification. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The custom result verifiers of some functions provides a compare() API that can be used to
compare the expected and actual results after certain transformation. This is needed for
functions like
avg(interval) -> intervalbecause the result of this function can have a smallprecision error that should be tolerated. However, the window fuzzer used to only support
the verify() API of custom result verifiers. This diff makes the window fuzzer to use the
compare() API as well when available.
Differential Revision: D68507422