fix(json_parse): Clear state after encountering an error #12150
Closed
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D68534578 |
…ubator#12150) Summary: `json_parse` if it encounters an error and throws in a sensitive part of the code , doesnt clear out its previous state when processing the next row. This can cause it to throw when processing the next valid row. Reviewed By: xiaoxmeng, amitkdutta Differential Revision: D68534578
kgpai
force-pushed
the
export-D68534578
branch
from
89ecf0f to
5f34ab9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68534578 |
|
This pull request has been merged in f910bb1. |
|
Conbench analyzed the 0 benchmark runs that triggered this notification. None of the specified runs were found on the Conbench server. The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
json_parseif it encounters an error and throws in a sensitive part of the code , doesnt clear out its previous state when processing the next row. This can cause it to throw when processing the next valid row.Differential Revision: D68534578