Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add IoStatistics in ReadFile to collect storage statistics #12160

Closed
wants to merge 1 commit into from
Closed

feat: Add IoStatistics in ReadFile to collect storage statistics #12160

wants to merge 1 commit into from

Conversation

kewang1024
Copy link
Contributor

@kewang1024 kewang1024 commented Jan 24, 2025 •
edited
Loading

image

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 24, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 24, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 03a9543
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6795bd7945b9500008ad51d9

@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kewang1024 kewang1024 force-pushed the table-scan-stats branch 2 times, most recently from 21b6341 to f33a066 Compare January 24, 2025 08:40
@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kewang1024 kewang1024 force-pushed the table-scan-stats branch 13 times, most recently from 81fa1ee to c3aa75e Compare January 25, 2025 00:57
@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kewang1024 kewang1024 changed the title feat: Add storage stats in IoStatistics feat: Add IoStatistics in ReadFile to collect storage related statistics Jan 25, 2025
@kewang1024 kewang1024 changed the title feat: Add IoStatistics in ReadFile to collect storage related statistics feat: Add IoStatistics in ReadFile to collect storage statistics Jan 25, 2025
@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

kewang1024 added a commit to kewang1024/velox that referenced this pull request Jan 25, 2025
@kewang1024 @facebook-github-bot
feat: Add IoStatistics in ReadFile to collect storage statistics (fac…
c81d0b1 
…ebookincubator#12160)

Summary: Pull Request resolved: facebookincubator#12160

Differential Revision: D68598642

Pulled By: kewang1024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68598642

@yuandagits
Copy link
Contributor

Left minor in phab

kewang1024 added a commit to kewang1024/velox that referenced this pull request Jan 26, 2025
@kewang1024 @facebook-github-bot
feat: Add IoStatistics in ReadFile to collect storage statistics (fac…
677a42c 
…ebookincubator#12160)

Summary:
1.Add IoStatistics in ReadFile to collect storage statistics
2.Collect WS stats in IoStatistics and add to runtimeStats

{F1974649191} 


Test Plan:
Deployed to a test cluster
Java: 20250125_082712_05968_cwjy8
S1-wsInRegionReadBytes	985.81 MB	1232	322.87 KB	1.00 MB

CPP: 20250125_095038_00000_sgud6
S1-TableScan.0.wsInRegionReadBytes	908.81 MB	154	5.80 MB	5.97 MB

Reviewed By: yuandagits

Differential Revision: D68598642

Pulled By: kewang1024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68598642

@kewang1024 @facebook-github-bot
feat: Add IoStatistics in ReadFile to collect storage statistics (fac…
03a9543 
…ebookincubator#12160)

Summary:
1.Add IoStatistics in ReadFile to collect storage statistics
2.Collect WS stats in IoStatistics and add to runtimeStats

{F1974649191} 


Test Plan:
Deployed to a test cluster
Java: 20250125_082712_05968_cwjy8
S1-wsInRegionReadBytes	985.81 MB	1232	322.87 KB	1.00 MB

CPP: 20250125_095038_00000_sgud6
S1-TableScan.0.wsInRegionReadBytes	908.81 MB	154	5.80 MB	5.97 MB

Reviewed By: yuandagits

Differential Revision: D68598642

Pulled By: kewang1024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68598642

@kewang1024 kewang1024 requested a review from yuandagits January 26, 2025 05:03
@facebook-github-bot
Copy link
Contributor

@kewang1024 merged this pull request in cb3f8b6.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 0 benchmark runs that triggered this notification.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuandagits yuandagits yuandagits approved these changes

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kewang1024 @facebook-github-bot @yuandagits