Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add single node mode for query trace tool #12171

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

duanmeng
Copy link
Collaborator

@duanmeng duanmeng commented Jan 25, 2025

The TaskTraceMetadataWriter serializes and writes the entire plan
fragment to the task metadata file. Then, the TaskTraceMetadataReader
deserializes the task metadata, extracts the target trace node, and constructs
a replay node by using it.

This PR adds a single node mode that TaskTraceMetadataWriter only serializes
the mirror node constructed using the target trace node. In this mode, it replaces
its source nodes with DummySourceNode to retain the trace node's input types.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 25, 2025
Copy link

netlify bot commented Jan 25, 2025

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 2dab5c3
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6794ce6a040dad0008d218b3

@duanmeng duanmeng changed the title feat: Add single trace node mode feat: Add single node mode for query trace tool Jan 25, 2025
@duanmeng duanmeng requested a review from xiaoxmeng January 25, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants