Fix PPO names (#62)

facebookresearch · Feb 1, 2024 · 0305223 · 0305223
1 parent ca33835
commit 0305223
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/benchmarl/algorithms/ippo.py b/benchmarl/algorithms/ippo.py
@@ -234,8 +234,8 @@ def process_batch(self, group: str, batch: TensorDictBase) -> TensorDictBase:
             loss = self.get_loss_and_updater(group)[0]
             loss.value_estimator(
                 batch,
-                params=loss.critic_params,
-                target_params=loss.target_critic_params,
+                params=loss.critic_network_params,
+                target_params=loss.target_critic_network_params,
             )
 
         return batch

diff --git a/benchmarl/algorithms/mappo.py b/benchmarl/algorithms/mappo.py
@@ -238,8 +238,8 @@ def process_batch(self, group: str, batch: TensorDictBase) -> TensorDictBase:
             loss = self.get_loss_and_updater(group)[0]
             loss.value_estimator(
                 batch,
-                params=loss.critic_params,
-                target_params=loss.target_critic_params,
+                params=loss.critic_network_params,
+                target_params=loss.target_critic_network_params,
             )
 
         return batch