Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Environment] MAgent2 #137

Merged
merged 26 commits into from
Nov 29, 2024
Merged

Conversation

JoseLuisC99
Copy link
Contributor

@JoseLuisC99 JoseLuisC99 commented Oct 8, 2024

MAgent2 integration in BenchMARL. Related issued: #135

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2024
@matteobettini
Copy link
Collaborator

Feel free to poke me when this is ready

@JoseLuisC99
Copy link
Contributor Author

Sure, I am waiting for approval from MAgent2 before pushing my changes. Without it, an error will be raised if we create a video.

I will continue working on this environment to test it and fix any errors.

@matteobettini
Copy link
Collaborator

Ok cool, eventually we will need to add:

  • tests and new ci script
  • docs (readme and sphinx)
  • if you have finetuned some parameters that woulod be incredible otherwise no worries

I will be able to help with any of this so if at any point you want me to take these tasks i can

@JoseLuisC99
Copy link
Contributor Author

JoseLuisC99 commented Oct 29, 2024

What other task should I add before I mark it as ready for review?
cc: @matteobettini

@matteobettini
Copy link
Collaborator

I think mainly docs and tests.

I can probably take care of those. Can you just make sure all runs fine and trains with all algos?

@JoseLuisC99 JoseLuisC99 marked this pull request as ready for review November 11, 2024 00:36
@matteobettini
Copy link
Collaborator

Sorry for the wait! I'll have a look and work on this this weekend

@matteobettini
Copy link
Collaborator

@JoseLuisC99 it seems that this does not work on the latest pip installed magent2 due to the fact that Farama-Foundation/MAgent2@9706565 is not in there yet. I think we need to wait for the magent2 repository to push a new release

@matteobettini matteobettini changed the title MAgent2 [Environment] MAgent2 Nov 24, 2024
@matteobettini
Copy link
Collaborator

matteobettini commented Nov 27, 2024

@JoseLuisC99 this is ready!

If it looks good for you too we can merge it!

For now we can tell the users to install from git and then change it to pip when there is a new release

@JoseLuisC99
Copy link
Contributor Author

@matteobettini sure!

@matteobettini matteobettini merged commit c78eb89 into facebookresearch:main Nov 29, 2024
12 of 14 checks passed
@JoseLuisC99 JoseLuisC99 deleted the magent2 branch November 29, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants