Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add on batch method #181

Merged
merged 4 commits into from
Dec 9, 2020
Merged

add on batch method #181

merged 4 commits into from
Dec 9, 2020

Conversation

nicofirst1
Copy link
Contributor

Refer to this issue

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 9, 2020
@nicofirst1
Copy link
Contributor Author

This

@nicofirst1
Copy link
Contributor Author

Actually, after some search, I found out that the issue is in the torch library. I added another catch here 58c3ed2

robertodessi
robertodessi reviewed Dec 9, 2020
View reviewed changes
egg/core/callbacks.py Outdated Show resolved Hide resolved
robertodessi
robertodessi reviewed Dec 9, 2020
View reviewed changes
egg/core/trainers.py Outdated Show resolved Hide resolved
robertodessi
robertodessi reviewed Dec 9, 2020
View reviewed changes
egg/core/trainers.py Outdated Show resolved Hide resolved
@robertodessi
Copy link
Contributor

Apart from the comments, it looks good, thanks! :)

@robertodessi robertodessi merged commit 46df9d0 into facebookresearch:master Dec 9, 2020
@robertodessi robertodessi mentioned this pull request Dec 10, 2020
Closed
@nicofirst1 nicofirst1 deleted the on_batch branch January 9, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertodessi robertodessi robertodessi left review comments

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicofirst1 @robertodessi @facebook-github-bot