Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed EMAConfig on line 1103. #5389

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Quicksticks-oss
Copy link

Before submitting

  • [ no] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • [ yes] Did you read the contributor guideline?
  • [ no need for an update] Did you make sure to update the docs?
  • [ no need] Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).
Fixed the metadata on line 1103 the help key was not in quotes.
I found this through my compiler which kept giving me this error

File "/home/disk1/q/main.dist/fairseq/dataclass/configs.py", line 1103, in EMAConfig
    default=False, metadata={help: "store exponential moving average shadow model"}

NameError: name 'help' is not defined

I then opened up the script in VSC and discovered the quotes where forgot so I just added them in and now it works. :)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃
Yup!

@Quicksticks-oss
Copy link
Author

Just wondering what the status of this pr. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants