Update Magnum to latest #2521
Open
Update Magnum to latest #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like an accident made in 94255f7 (September 2021).
Using SceneTools to perform a transformation and concatenation of all meshes in the file instead. The copy back to the ancient habitat MeshData structure is what makes this longer than it could be but I don't want to touch that as well now. With this, the Assimp::Assimp CMake target doesn't need to be found (or made) anymore, it was additionally errorneously linked to the bindings as well.
facebook-github-bot
added
the
CLA Signed
The applications got an overhaul for first-class touch and pen support, meaning the events are renamed now. Since GLFW doesn't support touch or pen, nothing else needs to be done really. Besides that, Magnum itself bundles the Find modules, meaning they don't need to have copies here anymore, unless used directly such as FindBullet.
mosra
force-pushed
the
update-magnum34
branch
from
7c160ae to
1341554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
My 34th PR updating Magnum? It's been going on for a while it seems.
The changes go back to July, so here's just a condensed list of what you might be interested in:
FindMagnumetc bundled would provide a slightly better error message when a system-wide dependency is not found, but given that Habitat defaults to bundled Magnum I don't think it's worth the pain to continue to have them here.Containers, are now marked asconstexpron C++14. Let me know if you need any others.Platform::Application::Mouse*EventAPIs got deprecated in favor ofPointer*Event, which is an abstraction over a mouse as well as a touch and pen input. High-level intro to pointer events is here. Unfortunately (fortunately?) GLFW doesn't support touch input at all, so for you it's just a matter of renaming and not having to care about anything else, which I did in this PR. (Not for Python though, but @jturner65 promised he'll be on that right after.)MeshToolslibrary finally got nice high-level intro docs, and as a side effect some APIs are now slightly easier to use. (Basically it was easier to fix some APIs to behave better than to have to explain why they're shitty like that.)Text::Renderer2DAPIs. Yet.How Has This Been Tested
🍏