Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in Doc example #2838

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

akshay-raj-dhamija
Copy link
Contributor

@akshay-raj-dhamija akshay-raj-dhamija commented Jan 17, 2024

The example in the documentation had a minor copy-paste error. This PR addresses that typo.

Changed
assert isinstance(obj_none, MyTarget)
to
assert isinstance(obj_all, MyTarget)

Have you read the Contributing Guidelines on pull requests?

Yes

Typo fix
changed 
`assert isinstance(obj_none, MyTarget)` 
to 
`assert isinstance(obj_all, MyTarget)`
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2024
@odelalleau odelalleau self-requested a review January 17, 2024 23:08
Copy link
Collaborator

@odelalleau odelalleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@odelalleau
Copy link
Collaborator

Looks like we really need to fix CI, but this shouldn't have anything to do with your PR => merging, thank you!

@odelalleau odelalleau merged commit d425fe6 into facebookresearch:main Jan 18, 2024
14 of 29 checks passed
@akshay-raj-dhamija akshay-raj-dhamija deleted the patch-1 branch January 18, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants