-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert facebookresearch/hydra to GitHub Actions #2973
Merged
jesszzzz
merged 8 commits into
main
from
convert-facebookresearch-hydra-to-actions-20241022-163241
Oct 28, 2024
Merged
Convert facebookresearch/hydra to GitHub Actions #2973
jesszzzz
merged 8 commits into
main
from
convert-facebookresearch-hydra-to-actions-20241022-163241
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Oct 22, 2024
jesszzzz
force-pushed
the
convert-facebookresearch-hydra-to-actions-20241022-163241
branch
19 times, most recently
from
October 24, 2024 17:26
5446b87
to
03a85cc
Compare
jesszzzz
force-pushed
the
convert-facebookresearch-hydra-to-actions-20241022-163241
branch
from
October 24, 2024 17:26
03a85cc
to
b21b933
Compare
jesszzzz
force-pushed
the
convert-facebookresearch-hydra-to-actions-20241022-163241
branch
2 times, most recently
from
October 25, 2024 14:45
6f3d326
to
b48d803
Compare
jesszzzz
force-pushed
the
convert-facebookresearch-hydra-to-actions-20241022-163241
branch
3 times, most recently
from
October 25, 2024 18:10
c8d8411
to
2455551
Compare
jesszzzz
force-pushed
the
convert-facebookresearch-hydra-to-actions-20241022-163241
branch
3 times, most recently
from
October 25, 2024 20:44
4d87351
to
0dff57c
Compare
jesszzzz
force-pushed
the
convert-facebookresearch-hydra-to-actions-20241022-163241
branch
from
October 25, 2024 21:20
0dff57c
to
3e9ba4c
Compare
Sanjay-Ganeshan
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly changing double quotes to single quotes
jesszzzz
deleted the
convert-facebookresearch-hydra-to-actions-20241022-163241
branch
October 28, 2024 16:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipeline migrated from CircleCI 🎉
PR originally generated with
gh actions-importer migrate circle-ci --target-url https://github.com/facebookresearch/hydra.git --output-dir migrate --circle-ci-project hydra
Added the following changes:
~
which messes up the parser without the quotesPYTHONIOENCODING
env varNote there's probably still some inefficiency in this setup but not a priority to improve it right now.
Test:
See CI signals. Note the CircleCI failure is expected and we'll disable it once this PR is approved.